Skip to content
This repository has been archived by the owner on Mar 4, 2022. It is now read-only.

Bug: propagate -- extra flags on builder run <task1> && builder run <task2> #92

Closed
2 tasks
ryan-roemer opened this issue Feb 18, 2016 · 0 comments
Closed
2 tasks
Labels

Comments

@ryan-roemer
Copy link
Member

The -- propagation is very naive right now as well as builder detection. In this case, we only propagate to one of the two tasks:

// package.json
    "one": "echo one",
    "two": "echo two",
    "all": "builder run one && builder run two"

Produces this:

$ builder run all -- --hi
[builder:proc:start] Command: builder run one && builder run two -- --hi
[builder:proc:start] Command: echo one
one
[builder:proc:start] Command: echo two --hi
two --hi

Task:

  • Propagate the flag to builder ... && builder ... tasks (maybe via environment?)
  • Have more sophisticated builder task detection for echo NOT_BUILDER && builder run <task> too
ryan-roemer added a commit that referenced this issue Feb 19, 2016
* Refactor to use environment instead of `--` appending to propagate to
  `builder` commands. Fixes #92
* Add note for #93
* Remove `argv-split` as we're not parsing commands anymore.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant