This repository has been archived by the owner on Mar 4, 2022. It is now read-only.
Change to more permissive sibling dependency inference. #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have a successful local install of |
|
awesome! can you please do a version bump with this fix? |
ryan-roemer
added a commit
that referenced
this pull request
Nov 25, 2015
Change to more permissive sibling dependency inference.
| // Require resolve it | ||
| var modPath = require.resolve(name); | ||
| pkgPath = path.join(modPath, "package.json"); | ||
| return require(pkgPath); |
There was a problem hiding this comment.
This will break if the archetype has a main file (our current archetype doesn't, but I don't think we should break here if an archetype has one for some reason). For example when I try this on lodash:
> require("path").join(require.resolve("lodash"), "package.json")
'/Users/brianbeck/Projects/Tests/npm-test/node_modules/lodash/dist/lodash.js/package.json'Also, is there a good reason not to just use require.resolve as the one-and-only way? I really believe that needing to crawl up the tree to find the archetype will end up being the common case, not an edge case.
|
Released as |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30
require.resolveas another fallback method./cc @exogen @boygirl