Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generating a bundle fails if an ESP is not mounted #132

Closed
WhyNotHugo opened this issue Mar 23, 2022 · 0 comments · Fixed by #156
Closed

Generating a bundle fails if an ESP is not mounted #132

WhyNotHugo opened this issue Mar 23, 2022 · 0 comments · Fixed by #156

Comments

@WhyNotHugo
Copy link
Contributor

Trying to run sbctl bundle ... --esp /path/to/esp/ fails if GetESP cannot find an ESP (e.g.: if there's no ESP mounted).

This negates the usefulness of the --esp flag in cases where the ESP cannot be automatically detected.

The error is because NewBundle errors immediately if no ESP can be found:

sbctl/bundles.go

Lines 78 to 81 in 3c0ddb5

esp, err := GetESP()
if err != nil {
return
}

However, it should not fail if the user is passing one explicitly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix crash when ESP is not mounted WhyNotHugo/sbctl
1 participant
@WhyNotHugo