Fix crash when ESP is not mounted #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous rule setup SHOULD work, but I found several tools messed up and were ignoring `cmd/sbctl`. E.g.: `ag` did not recurse into it when searching.
Generating a new bundle with an unmounted ESP would crash trying to find one, even if one was explicitly specified. This was due to Bundle instances always being created with a discovered ESP path. However, this path is always overwritten based on the value provided by the user, meaning that this default is unused and always overwritten. This changes NewBundle to simply use an empty ESP if finding one fails. This has no impact on `sbctl` itself. This change COULD impact applications using this codes as a library, but this only affects code that previously panicked. Fixes: #132
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generating a new bundle with an unmounted ESP would crash trying to find
one, even if one was explicitly specified.
This was due to Bundle instances always being created with a discovered
ESP path. However, this path is always overwritten based on the value
provided by the user, meaning that this default is unused and always
overwritten.
This changes NewBundle to simply use an empty ESP if finding one fails.
This has no impact on
sbctlitself. This change COULD impactapplications using this codes as a library, but this only affects code
that previously panicked.
Fixes: #132