Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Introduce prepare-integration make target #298

Closed

Conversation

jimmykarily
Copy link
Contributor

to prepare the VM filesystem for the tests.
This target is suppused to be run like so:

make prepare-integration integration

but currently the filesystem it creates is not bootable for some reason.

@Foxboron looking at the code it seems that there is some way to run the integration test but it's relying on things outside git. I tried to fill in the missing parts by wrapping the make_image.sh script in a docker command that would make it possible to run it locally.

I remember you mentioned u-root being used in go-uefi so I wonder if I should ditch this and try to use u-root to build an initramfs that has sbctl in it. What do you think? I'm also fine dropping this completely until you find time to work on it yourself. I only mean to help, no pressure :).

to prepare the VM filesystem for the tests.
This target is suppused to be run like so:

make prepare-integration integration

but currently the filesystem it creates is not bootable for some reason.

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
@jimmykarily jimmykarily temporarily deployed to Build, sign, release binaries April 23, 2024 10:44 — with GitHub Actions Inactive
@jimmykarily jimmykarily temporarily deployed to Build, sign, release binaries April 23, 2024 10:44 — with GitHub Actions Inactive
@jimmykarily jimmykarily temporarily deployed to Build, sign, release binaries April 23, 2024 10:44 — with GitHub Actions Inactive
@Foxboron
Copy link
Owner

Foxboron commented Apr 23, 2024

Thanks for taking stabs at the project :)

I remember you mentioned u-root being used in go-uefi so I wonder if I should ditch this and try to use u-root to build an initramfs that has sbctl in it. What do you think? I'm also fine dropping this completely until you find time to work on it yourself. I only mean to help, no pressure :).

I think moving the current tests from the old vmtest library to the u-root library like I've done in go-uefi would make all of this simpler.

@jimmykarily
Copy link
Contributor Author

Thanks for taking stabs at the project :)

I remember you mentioned u-root being used in go-uefi so I wonder if I should ditch this and try to use u-root to build an initramfs that has sbctl in it. What do you think? I'm also fine dropping this completely until you find time to work on it yourself. I only mean to help, no pressure :).

I think moving the current tests from the old vmtest library to the u-root library like I've done in go-uefi would make all of this simpler.

Mind me giving it a try?

@Foxboron
Copy link
Owner

Mind me giving it a try?

Sure! Feel free :)

@jimmykarily
Copy link
Contributor Author

Closing this PR to try a different approach as described above.

@jimmykarily jimmykarily deleted the run-integration-locally branch April 25, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants