Fixed lint issues

Signed-off-by: Morten Linderud <morten@linderud.pw>

cmd/sbctl/main.go

@@ -48,7 +48,7 @@ func JsonOut(v interface{}) error {
 	if err != nil {
 		return fmt.Errorf("could not marshal json: %w", err)
 	}
-	fmt.Fprintf(os.Stdout, string(b))
+	fmt.Fprint(os.Stdout, string(b))
 	return nil
 }
 

cmd/sbctl/status.go

@@ -19,7 +19,7 @@ var statusCmd = &cobra.Command{
 func RunStatus(cmd *cobra.Command, args []string) error {
 	ret := map[string]interface{}{}
 	if _, err := os.Stat("/sys/firmware/efi/efivars"); os.IsNotExist(err) {
-		return fmt.Errorf("system is not booted with UEFI!")
+		return fmt.Errorf("system is not booted with UEFI")
 	}
 	u, err := sbctl.GetGUID()
 	if err != nil {

keys.go

@@ -164,7 +164,7 @@ func SignFile(key, cert, file, output, checksum string) error {
 
 	// Check file exists before we do anything
 	if _, err := os.Stat(file); os.IsNotExist(err) {
-		return fmt.Errorf("%s does not exist!", file)
+		return fmt.Errorf("%s does not exist", file)
 	}
 
 	// Let's check if we have signed it already AND the original file hasn't changed
@@ -183,10 +183,10 @@ func SignFile(key, cert, file, output, checksum string) error {
 		return fmt.Errorf("couldn't access %s", key)
 	}
 
-	logging.Ok("signing %s", file)
+	logging.Ok("Signing %s", file)
 	_, err = exec.Command("sbsign", "--key", key, "--cert", cert, "--output", output, file).Output()
 	if err != nil {
-		return fmt.Errorf("Failed signing file: %w", err)
+		return fmt.Errorf("failed signing file: %w", err)
 	}
 	return nil
 }

logging/logging.go

@@ -12,20 +12,17 @@ var (
 	NotOkSym = "✘"
 	WarnSym  = "‼"
 	UnkwnSym = "⁇"
-	ErrSym   = "⁇"
 )
 var (
 	OkSymText    = "[+]"
 	NotOkSymText = "[-]"
 	WarnSymText  = "[!]"
 	UnkwnSymText = "[?]"
-	ErrSymText   = "[?]"
 )
 
 var (
 	ok    string
 	notok string
-	err   string
 	warn  string
 	unkwn string
 )
@@ -109,14 +106,12 @@ func init() {
 	if ok := os.Getenv("EFIBOOTCTL_UNICODE"); ok == "0" {
 		OkSym = OkSymText
 		NotOkSym = NotOkSymText
-		ErrSym = ErrSymText
 		WarnSym = WarnSymText
 		UnkwnSym = UnkwnSymText
 	}
 
 	ok = color.New(color.FgGreen, color.Bold).Sprintf(OkSym)
 	notok = color.New(color.FgRed, color.Bold).Sprintf(NotOkSym)
-	err = color.New(color.FgRed, color.Bold).Sprintf(ErrSym)
 	warn = color.New(color.FgYellow, color.Bold).Sprintf(WarnSym)
 	unkwn = color.New(color.FgRed, color.Bold).Sprintf(UnkwnSym)
 	PrintOn()

sbctl.go

@@ -176,7 +176,7 @@ func Sign(file, output string, enroll bool) error {
 
 	files, err := ReadFileDatabase(DBPath)
 	if err != nil {
-		return fmt.Errorf("Couldn't open database: %s", DBPath)
+		return fmt.Errorf("couldn't open database: %s", DBPath)
 	}
 	if entry, ok := files[file]; ok {
 		err = SignFile(DBKey, DBCert, entry.File, entry.OutputFile, entry.Checksum)
@@ -224,14 +224,14 @@ var efivarFSFiles = []string{
 	"/sys/firmware/efi/efivars/db-d719b2cb-3d3a-4596-a3bc-dad00e67656f",
 }
 
-var ErrImmutable = errors.New("You need to chattr -i files in efivarfs")
+var ErrImmutable = errors.New("you need to chattr -i files in efivarfs")
 
 func SyncKeys() error {
 	errImmuable := false
 	for _, file := range efivarFSFiles {
 		b, err := IsImmutable(file)
 		if err != nil {
-			return fmt.Errorf("Couldn't read file: %s", file)
+			return fmt.Errorf("couldn't read file: %s", file)
 		}
 		if !b {
 			logging.Warn("File is immutable: %s", file)
@@ -243,7 +243,7 @@ func SyncKeys() error {
 	}
 	synced := SBKeySync(KeysPath)
 	if !synced {
-		return errors.New("Couldn't sync keys")
+		return errors.New("couldn't sync keys")
 	} else {
 		logging.Ok("Synced keys!")
 	}
@@ -301,7 +301,7 @@ func CreateBundle(bundle Bundle) error {
 		logging.Warn(err.Error())
 	}
 	if !out {
-		return fmt.Errorf("failed to generate bundle %s!", bundle.Output)
+		return fmt.Errorf("failed to generate bundle %s", bundle.Output)
 	}
 
 	return nil
@@ -311,7 +311,7 @@ func GenerateAllBundles(sign bool) error {
 	logging.Println("Generating EFI bundles....")
 	bundles, err := ReadBundleDatabase(BundleDBPath)
 	if err != nil {
-		return fmt.Errorf("Couldn't open database: %s", BundleDBPath)
+		return fmt.Errorf("couldn't open database: %s", BundleDBPath)
 	}
 	out_create := true
 	out_sign := true
@@ -332,11 +332,11 @@ func GenerateAllBundles(sign bool) error {
 	}
 
 	if !out_create {
-		return errors.New("Error generating EFI bundles")
+		return errors.New("error generating EFI bundles")
 	}
 
 	if !out_sign {
-		return errors.New("Error signing EFI bundles")
+		return errors.New("error signing EFI bundles")
 	}
 
 	return nil