Skip to content
This repository has been archived by the owner on Apr 21, 2022. It is now read-only.

feat: add plugin-bundle-types #21

Closed
wants to merge 1 commit into from

Conversation

layershifter
Copy link

This PR adds a new plugin to generate a bundle of TS definitions, it makes a big sense for web and node builds.

@layershifter
Copy link
Author

/cc @FredKSchott

@FredKSchott
Copy link
Owner

This is great! I was actually looking for something like this a while ago, but couldn't get it to work. How stable is dts-bundle-generator? Does it run successfully 100% of the time? Is there anything that can go in a type definition file that it can't handle?

@layershifter
Copy link
Author

layershifter commented Mar 7, 2019

https://www.npmjs.com/package/dts-bundle-generator#known-limitations
They have an own list of limitations, for small packages that I have tried with this plugin works like a charm.

Swatinem/rollup-plugin-dts#5 - this issue contains some compassion on issues dts-bundle-generator

@FredKSchott
Copy link
Owner

FredKSchott commented Mar 9, 2019

Ah, yes that's right. I ran into similar problems when I tried this originally.

This is something that I very much want, but right now I'd be against publishing an official bundler with so many caveats/limitations. I would definitely point to it as a community plugin though, and am currently working on a page on pikapkg.com to highlight these even better.

@layershifter
Copy link
Author

Okay, I understand your concern there 👍
I will publish it as own package.

@FredKSchott
Copy link
Owner

Great, thanks for understanding.

And please do publish it yourself! And once you do, link it here so that we can add it to the README (or feel free to create that PR yourself)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants