add tests

src/config.ts

@@ -15,7 +15,6 @@ type DeepPartial<T> = {
 // interface this library uses internally
 export interface SnowpackConfig {
   source: 'local' | 'pika';
-  dependencies?: {[packageName: string]: string};
   webDependencies?: string[];
   dedupe?: string[];
   namedExports?: {[filepath: string]: string[]};
@@ -70,7 +69,6 @@ const configSchema = {
   type: 'object',
   properties: {
     source: {type: 'string'},
-    dependencies: {type: 'object'},
     webDependencies: {type: 'array', items: {type: 'string'}},
     dedupe: {
       type: 'array',

src/index.ts

@@ -496,7 +496,6 @@ export async function cli(args: string[]) {
 
   const {
     installOptions: {clean, dest, exclude, include},
-    dependencies,
     webDependencies,
     source,
   } = config;
@@ -512,7 +511,6 @@ export async function cli(args: string[]) {
   const implicitDependencies = [
     ...Object.keys(pkgManifest.peerDependencies || {}),
     ...Object.keys(pkgManifest.dependencies || {}),
-    ...Object.keys(dependencies || {}),
   ];
   const hasBrowserlistConfig =
     !!pkgManifest.browserslist ||

src/resolve-remote.ts

@@ -87,14 +87,12 @@ export async function resolveTargetsFromRemoteCDN(
   pkgManifest: any,
   config: SnowpackConfig,
 ) {
-  const {dependencies} = config;
   const downloadQueue = new PQueue({concurrency: 16});
   const newLockfile: ImportMap = {imports: {}};
 
   const allInstallSpecifiers = new Set(installTargets.map(dep => dep.specifier));
   for (const installSpecifier of allInstallSpecifiers) {
     const installSemver: string =
-      (dependencies || {})[installSpecifier] ||
       (pkgManifest.dependencies || {})[installSpecifier] ||
       (pkgManifest.devDependencies || {})[installSpecifier] ||
       (pkgManifest.peerDependencies || {})[installSpecifier] ||

test/integration/runner.js

@@ -3,8 +3,13 @@ const path = require('path');
 const fs = require('fs').promises;
 const {readdirSync, readFileSync} = require('fs');
 const execa = require('execa');
+const rimraf = require('rimraf');
 const dircompare = require('dir-compare');
 
+const KEEP_LOCKFILE = [
+  'source-pika-lockfile', // We explicitly want to test the lockfile in this test
+];
+
 const SKIP_FILE_CHECK = [
   'config-rollup', // only expected-output.txt is needed for the test, and Windows comparison fails because of backslashes
 ];
@@ -36,6 +41,12 @@ for (const testName of readdirSync(__dirname)) {
   }
 
   test(testName, async () => {
+    // Prepare test directory
+    const testDir = path.join(__dirname, testName);
+    if (!KEEP_LOCKFILE.includes(testName)) {
+      rimraf.sync(path.join(testDir, 'snowpack.lock.json'));
+    }
+
     const {all} = await execa('npm', ['run', `TEST`, `--silent`], {
       cwd: path.join(__dirname, testName),
       reject: false,
@@ -48,6 +59,17 @@ for (const testName of readdirSync(__dirname)) {
       stripWhitespace(expectedOutput),
     );
 
+    // Test Lockfile (if one exists)
+    const expectedLockLoc = path.join(__dirname, testName, 'expected-lock.json');
+    const expectedLock = await fs
+      .readFile(expectedLockLoc, {encoding: 'utf8'})
+      .catch((/* ignore */) => null);
+    if (expectedLock) {
+      const actualLockLoc = path.join(__dirname, testName, 'snowpack.lock.json');
+      const actualLock = await fs.readFile(actualLockLoc, {encoding: 'utf8'});
+      assert.strictEqual(stripWhitespace(actualLock), stripWhitespace(expectedLock));
+    }
+
     const expectedWebDependenciesLoc = path.join(__dirname, testName, 'expected-install');
     const actualWebDependenciesLoc = path.join(__dirname, testName, 'web_modules');
     const expectedWebDependencies = await fs.readdir(expectedWebDependenciesLoc).catch(() => {});

test/integration/source-pika-lockfile/expected-install/import-map.json

@@ -0,0 +1,5 @@
+{
+  "imports": {
+    "async": "./async.js"
+  }
+}

test/integration/source-pika-lockfile/expected-lock.json

@@ -0,0 +1,5 @@
+{
+  "imports": {
+    "async": "https://cdn.pika.dev/async@v3.1.0-ENwq8gsjdqg55EqedqGF/minified"
+  }
+}

test/integration/source-pika-lockfile/expected-output.txt

@@ -0,0 +1,2 @@
+- snowpack installing...
+✔ snowpack installed: async.

test/integration/source-pika-lockfile/package.json

@@ -0,0 +1,11 @@
+{
+  "description": "Test that the lockfile import URLs & version info are used",
+  "scripts": {
+    "TEST": "node ../../../pkg/dist-node/index.bin.js --source pika"
+  },
+  "snowpack": {
+    "webDependencies": [
+      "async"
+    ]
+  }
+}

test/integration/source-pika-lockfile/snowpack.lock.json

@@ -0,0 +1,5 @@
+{
+  "imports": {
+    "async": "https://cdn.pika.dev/async@v3.1.0-ENwq8gsjdqg55EqedqGF/minified"
+  }
+}