Eliminate dead code (CID #1603583) #5351
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since args was just initialized to NULL and never changed, the xlat_func_args_set() call done if args is non-NULL never happens. (Said call is the only use of xlat_redundant_args.) Coverity rightly notices the dead code. That said, it's hard not to think that the original author didn't want to set args to a non-NULL value at some point. This PR will solve the Coverity issue and won't change semantics, but at some point it merits reconsideration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since args was just initialized to NULL and never changed, the xlat_func_args_set() call done if args is non-NULL never happens. (Said call is the only use of xlat_redundant_args.) Coverity rightly notices the dead code.
That said, it's hard not to think that the original author didn't want to set args to a non-NULL value at some point. This PR will solve the Coverity issue and won't change semantics, but at some point it merits reconsideration.