Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

refactor: twitter share feature #316

Merged
merged 8 commits into from
Jun 22, 2022
Merged

refactor: twitter share feature #316

merged 8 commits into from
Jun 22, 2022

Conversation

pedronauck
Copy link
Contributor

✨ Fix #311
✨ Fix #303
✨ Fix #302

@pedronauck pedronauck added the enhancement New feature or request label Jun 22, 2022
@pedronauck pedronauck self-assigned this Jun 22, 2022
@pedronauck pedronauck enabled auto-merge (squash) June 22, 2022 19:48
adlerjohn
adlerjohn reviewed Jun 22, 2022
View reviewed changes
Copy link
Contributor

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good. One change I'd make is that: if the user clicks the Twitter button then I think it should directly make the intent to Tweet, instead of going to an additional popup that basically amounts to "are you sure you want to tweet?"

@pedronauck
Copy link
Contributor Author

Looking pretty good. One change I'd make is that: if the user clicks the Twitter button then I think it should directly make the intent to Tweet, instead of going to an additional popup that basically amounts to "are you sure you want to tweet?"

Makes sense

@pedronauck pedronauck merged commit 57ceccd into master Jun 22, 2022
@pedronauck pedronauck deleted the refac/share-btn branch June 22, 2022 21:28
@adlerjohn adlerjohn mentioned this pull request Jun 22, 2022
Closed
pedronauck added a commit that referenced this pull request Jun 24, 2022
@pedronauck
Merge branch 'master' of github.com:FuelLabs/swayswap into refac/swap
0107f73 
* 'master' of github.com:FuelLabs/swayswap: (21 commits)
  fix: change css to be compatible with safari on ios 14 (#345)
  feat: add tx links for add/remove liquidity (#338)
  feat: improve height controll to avoid content hidden and colissions (#339)
  fix: get current blockheight to add on deadline (#342)
  fix: increase deadline (#341)
  feat: avoid multiple error notifications (#336)
  feat: loading button size (#335)
  chore: Revert "chore: remove launch app button on home" (#330)
  feat: make logo clickable (#327)
  feat: add more contrast to home text (#329)
  chore: remove launch app button on home (#325)
  chore: remove redundant docs link in header (#324)
  refactor: share button link direct to twitter (#321)
  feat: update contract ids on gh release (#319)
  refactor: twitter share feature (#316)
  feat: add eth and token amount on init pool action (#318)
  chore: fix typo (#317)
  style: bump tx feedback 5s -> 8s (#313)
  feat: add block explorer links on swap feedback and wallet info (#308)
  feat: improve checkbox ui for legal disclaimer (#310)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adlerjohn adlerjohn adlerjohn left review comments

@luizstacio luizstacio luizstacio approved these changes

Assignees

@pedronauck pedronauck

Labels
enhancement New feature or request
Projects
Fuel Network
Archived in project
SwaySwap
Status: Done
Milestone
No milestone
3 participants
@pedronauck @adlerjohn @luizstacio