Fix NPE bug when creating connection group in ConnectionManager

- The NPE will occur when multiple threads are trying to create the connection group for the same namespace Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Fxdemon · Jan 31, 2019 · cd02fad · cd02fad
1 parent 412e1ec
commit cd02fad
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/...t/src/main/java/com/alibaba/csp/sentinel/cluster/server/connection/ConnectionManager.java b/...t/src/main/java/com/alibaba/csp/sentinel/cluster/server/connection/ConnectionManager.java
@@ -55,7 +55,7 @@ public static ConnectionGroup getOrCreateGroup(String namespace) {
         ConnectionGroup group = CONN_MAP.get(namespace);
         if (group == null) {
             synchronized (CREATE_LOCK) {
-                if (CONN_MAP.get(namespace) == null) {
+                if ((group = CONN_MAP.get(namespace)) == null) {
                     group = new ConnectionGroup(namespace);
                     CONN_MAP.put(namespace, group);
                 }