Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Topping cannot secretely change to 10 euro #139

Closed
SuperVK opened this issue Mar 25, 2024 · 2 comments · Fixed by #148
Closed

[BUG] Topping cannot secretely change to 10 euro #139

SuperVK opened this issue Mar 25, 2024 · 2 comments · Fixed by #148
Labels
released

Comments

@SuperVK
Copy link
Member

SuperVK commented Mar 25, 2024

Despite it being very funny, we cannot have the top up secretly change to 10 euro when putting in a value below 10 euros.
@rinkp
Copy link
Member

rinkp commented Mar 26, 2024 •
edited
Loading

Despite it being very funny, we cannot have the top up secretly change to 10 euro when putting in a value below 10 euros.

  • I agree with @SuperVK on his second statement. We do not want to have a discussion with Mastercard about whether a member intended to top up 10 euros or not. We will almost certainly lose chargebacks as a result of that (and pay the €40 chargeback fee)

  • Additionally, I propose adding a similar note as in PR Implement all POS management pages. #16

CodeNamedRobin added a commit that referenced this issue Apr 3, 2024
@CodeNamedRobin
Fixed issue where topup was very silently changed. #139
0205d0d
CodeNamedRobin added a commit that referenced this issue Apr 3, 2024
@CodeNamedRobin
Fixed issue where topup was very silently changed. #139
ca0e4eb
@CodeNamedRobin CodeNamedRobin mentioned this issue Apr 3, 2024
Merged
CodeNamedRobin added a commit that referenced this issue Apr 10, 2024
@CodeNamedRobin @SuperVK
Bugfix/general fixes (#148)
c7783dd 
* Fix issue where balance is shown empty when zero #129.

* Fix issue where topup would show NaN when not filling in anything #137

* Fixed issue where navigating to transactions wouldnt work on mobile #138.

* Fixed issue where delete button on transaction modal shows for non-admin and non-BAC #143.

* Added special handling of waived fines in transaction table #145

* Fixed where invoices wouldn't show up correctly in transaction table #146.

* Fixed bug where users couldn't be created. #147

* Fixed issue where topup was very silently changed. #139

* Fixed issue where people could not top up to exactly 0 balance.

* Fixed type errors

* Fixed issue where fonts are not stored locally #144

* Fixed translations not being complete

* Fixed transactiontable

* Fixed invoice modal

* Fixed WaivedFine in overview

* Removed quickly appearing delete button on deposits

* Removed all the fonts we are not using

* Removed some console statements

---------

Co-authored-by: SuperVK <victor.klomp@gmail.com>
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix/general fixes GEWIS/sudosos-frontend
2 participants
@rinkp @SuperVK