Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetScaler terraform refactor #39

Merged
merged 12 commits into from
Sep 29, 2023
Merged

Conversation

LooseDevGoose
Copy link
Collaborator

Rework / Removals:
-Remove remote modules, make modules local
-Rework module structure
# contains all netscaler vsphere deployment code
-vpshere.netscaler.deployment

# contains all base configuration / best practice values / vservers / gateway etc
-netscaler.base.configuration

# Contains all letsencrypt related setup (including vservers)
netscaler.letsencrypt

-Reworked variable structure / names
-Removed string concatenation on complex variables
-Removed wait timers
-Removed time module
-Squashed endpoint resources
-Renamed all variables to match the other Terraform deployments

Fixes:
-Fixed reapply errors regarding the default timezone
-Fixed reapply errors when (re)defining an SSL profile

Additions:

-Included type checking on all (NetScaler related) variables. Security is all the rage.

-Incorperate object instead of maps for improved data structure.

-Included best practice of using tfvars file. Added a fully populated one for example config.

-Included license logic: you can also deploy a non-licensed (/freemium) netscaler now, and the configuration logic will adapt.

-Traveled the seven seas of NetScaler API documentation and optimized code logic flow (with appropiate pirate drinks).

-AAA vServer added

-Advanced authentication added

-Gateway now authenticates via auth profile with the AAA vserver

-Firmware versions 13.1 & 14.1 now supported.

-Virtual Servers / Services / and server objects no longer created through abstract looping; new structure with object mapping improves readability, scaling and debugging capability.. and other buzzwords the marketing people love.

Configuration changes:

-Enabled HTTP/2 on HTTP Profile
-Enabled Strong Password enforcement

@RyanBijkerk RyanBijkerk merged commit fe47d4f into GO-EUC:develop Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants