Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework / Removals:
-Remove remote modules, make modules local
-Rework module structure
# contains all netscaler vsphere deployment code
-vpshere.netscaler.deployment
-Reworked variable structure / names
-Removed string concatenation on complex variables
-Removed wait timers
-Removed time module
-Squashed endpoint resources
-Renamed all variables to match the other Terraform deployments
Fixes:
-Fixed reapply errors regarding the default timezone
-Fixed reapply errors when (re)defining an SSL profile
Additions:
-Included type checking on all (NetScaler related) variables. Security is all the rage.
-Incorperate object instead of maps for improved data structure.
-Included best practice of using tfvars file. Added a fully populated one for example config.
-Included license logic: you can also deploy a non-licensed (/freemium) netscaler now, and the configuration logic will adapt.
-Traveled the seven seas of NetScaler API documentation and optimized code logic flow (with appropiate pirate drinks).
-AAA vServer added
-Advanced authentication added
-Gateway now authenticates via auth profile with the AAA vserver
-Firmware versions 13.1 & 14.1 now supported.
-Virtual Servers / Services / and server objects no longer created through abstract looping; new structure with object mapping improves readability, scaling and debugging capability.. and other buzzwords the marketing people love.
Configuration changes:
-Enabled HTTP/2 on HTTP Profile
-Enabled Strong Password enforcement