[GT-145] Fixing, Refreshing and Enriching the Service Group Sample Data #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowan04
changed the title
rowan04
force-pushed
the
416-refresh-and-enrich-ServiceGroups-from-sampleData
branch
from
86c2469
to
899b061
Compare
|
rebased to remove extra commit |
|
to note - all service groups are currently incorrectly given only local scope |
fixed :) |
|
merge to update this branch with latest dev |
|
Codacy and codeclimate issues to be fixed. Other than that, ready for review |
rowan04
force-pushed
the
416-refresh-and-enrich-ServiceGroups-from-sampleData
branch
from
bb15afa
to
a7ba6e0
Compare
|
force push and rebase to merge 3 commits on code formatting fixes into 1 commit. |
gregcorbett
reviewed
Sep 13, 2023
gregcorbett
approved these changes
Sep 14, 2023
|
rebasing on top of latest dev |
- removing the old, outdated sample data from ServiceGroups.xml and ServiceGroupRoles.xml
…oyed - reorders when the service groups are deployed in the DeploySampleDataRunner.php file to be after the service endpoints - adds new code when service groups are created to actually add their services to them
- adding 2 more services to the sample data - this brings the total to 40, which is a nicer total than 38 - also does some fixes to some incorrect site sample data
- adds 7 service groups, all named SERVICE_GROUP_x - the groups have 5-8 services in each - SERVICE_GROUP_1 has 6 services from different sites - SERVICE_GROUP_2 has 5 services all from the same site - SERVICE_GROUP 4 and 5 both have all their services from sites in the same NGI - SERVICE_GROUP_7 has both EGI and Local scope - the rest have one or the other - each service is used in at least one service group - some services are used in 2 different service groups. one service is in 3 groups
- creates new file to allow the creation of service group level roles - adds new file to DeploySampleDataRunner
- each group has a service group administrator - so 7 users have the service group administrator role - old file that added service group roles deleted - as roles added in UsersAndRoles
…scope by default - before each service group was given just the local scope by default - this allows egi scopes to be added - and allows multiple scopes to be added for each service group
- as suggested by codeclimate and codacy
… array item - the array only ever has one data item in it - the foreach loop was taking each item from the array, which was just the one item, and setting it to a different variable - the new code sets the variable to the first and only item in the array instead, without the need for a loop
gregcorbett
force-pushed
the
416-refresh-and-enrich-ServiceGroups-from-sampleData
branch
from
9ec9488
to
9dea011
Compare
rowan04
deleted the
416-refresh-and-enrich-ServiceGroups-from-sampleData
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will resolve #416 when finished