Aarch64 fixes #80
Open
Aarch64 fixes #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the default TARGET_ARCH to none, otherwise it fails to build on architectures for which gcc doesn't support -m32 (such as aarch64)
Chars on aarch64 are unsigned by default, throwing a type conversion warning on compilation and a memory access violation when ran.
|
Hello @Candles and thanks for this proposal. We actually have an internal development branch that already includes these fixes. We were hoping to release it in 2023 but got delayed for a number of reasons. We'll hopefully be promoting this internal branch to the new |
|
I've looked better at the changes and there seems to be more than what we have in the private branch. I'm reopening the PR, and we can discuss these changes better when the internal branch is promoted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pair of fixes for running on aarch64. One resolves a Makefile issue preventing compilation and the other fixes an error caused by different default char signing between x86 and aarch64.