Revert unintentional change in behaviour when combining default and…

… `required` attributes (#293) Never add a field with the `default` attribute to a schema's `required` properties
GREsau · May 18, 2024 · 7ecaa7f · 7ecaa7f
1 parent cf5be1b
commit 7ecaa7f
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## [0.8.20] - 2024-05-18
+
+### Fixed:
+
+- Revert unintentional change in behaviour when combining `default` and `required` attributes (https://github.com/GREsau/schemars/issues/292)
+
 ## [0.8.19] - 2024-05-06
 
 ### Fixed:

diff --git a/Cargo.lock b/Cargo.lock
diff --git a/schemars/Cargo.toml b/schemars/Cargo.toml
@@ -3,7 +3,7 @@ name = "schemars"
 description = "Generate JSON Schemas from Rust code"
 homepage = "https://graham.cool/schemars/"
 repository = "https://github.com/GREsau/schemars"
-version = "0.8.19"
+version = "0.8.20"
 authors = ["Graham Esau <gesau@hotmail.co.uk>"]
 edition = "2021"
 license = "MIT"
@@ -14,7 +14,7 @@ build = "build.rs"
 rust-version = "1.60"
 
 [dependencies]
-schemars_derive = { version = "=0.8.19", optional = true, path = "../schemars_derive" }
+schemars_derive = { version = "=0.8.20", optional = true, path = "../schemars_derive" }
 serde = { version = "1.0", features = ["derive"] }
 serde_json = "1.0.25"
 dyn-clone = "1.0"

diff --git a/schemars/src/_private.rs b/schemars/src/_private.rs
@@ -131,7 +131,7 @@ pub fn insert_object_property<T: ?Sized + JsonSchema>(
     schema: Schema,
 ) {
     obj.properties.insert(key.to_owned(), schema);
-    if required || !(has_default || T::_schemars_private_is_option()) {
+    if !has_default && (required || !T::_schemars_private_is_option()) {
         obj.required.insert(key.to_owned());
     }
 }

diff --git a/schemars_derive/Cargo.toml b/schemars_derive/Cargo.toml
@@ -3,7 +3,7 @@ name = "schemars_derive"
 description = "Macros for #[derive(JsonSchema)], for use with schemars"
 homepage = "https://graham.cool/schemars/"
 repository = "https://github.com/GREsau/schemars"
-version = "0.8.19"
+version = "0.8.20"
 authors = ["Graham Esau <gesau@hotmail.co.uk>"]
 edition = "2021"
 license = "MIT"