Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cave Air not handled like air by most modules. #149

Closed
Bloo-dev opened this issue Jan 31, 2019 · 6 comments
Closed

Cave Air not handled like air by most modules. #149

Bloo-dev opened this issue Jan 31, 2019 · 6 comments
Labels
bug Something isn't working

Comments

@Bloo-dev
Copy link
Member

Most modules don't treat Cave Air the same as air. As a result modules with air checks don't work as intended in caverns, natural ponds, ravines, dungeons…

Expected Behavior

The Module should treat Cave Air just like normal air.

Current Behavior

Cave Air is treated like any non air block.

Possible Solution

Create a block tag #air, maybe even include it in the base.

Affected Modules (extend this list in the comments)

Shroomites (spores see cave air as a solid block)
Phantom Scarecrows (rockets explode in cave air)

@Bloo-dev Bloo-dev added the bug Something isn't working label Jan 31, 2019
@misode
Copy link
Member

misode commented Jan 31, 2019

Including common tags (like #air) in the base seems like a bad idea because that's going to cause incompatibility issues.

@Kroppeb
Copy link
Contributor

Kroppeb commented Jan 31, 2019

I think we should include a #air as many modules might have problems and Mojang still hasn't added a tag themselves.

@Kroppeb
Copy link
Contributor

Kroppeb commented Jan 31, 2019

List of modules testing for air:

  • Boots of Ostara:
    • Crops won't be planted on newly placed farmland in caves: gm4_boots_of_ostara\data\boots_of_ostara\functions\active.mcfunction
  • Custom Crafters: Not affected as the check is for when a crafter is broken, will always be air
  • Phantom Scarecrows:
    • rockets explode in cave air: gm4_phantom_scarecrows\data\phantom_scarecrows\tags\blocks\traversable.json
  • Pig tractors: same as above but it's littered with air checks, I think some of them might be able to be deleted
  • Shroomites:
    • spores see cave air as a solid block: gm4_shroomites\data\shroomites\tags\blocks\shroom_rootable.json
  • Zauber Cauldrons:
    • Idk what's happening with the poison potion here so idk if it's affected: gm4_zauber_cauldrons\data\zauber_cauldrons\functions\recipes\potions\poison.mcfunction

@Bloo-dev
Copy link
Member Author

Yes, Zauber Cauldrons is affected. Putting up the cauldron in a cave will prevent cobwebs from spawning upon recipe execution (poison IV potion). Though this will only work once since breaking the cobwebs would place air again

@andantet
Copy link
Contributor

andantet commented Mar 23, 2019

This other type wouldn't really affect much, but minecraft:void_air as well

Bloo-dev pushed a commit that referenced this issue Apr 28, 2019
* Update boots of ostara

* Update phantom scarecrows

* Update pig tractors

* Update shroomites

* Update zauber cauldrons
@misode
Copy link
Member

misode commented Jun 25, 2019

Reopen as this was only patched in 1.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants