Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Levity Affects Spectators #416

Closed
Bloo-dev opened this issue May 27, 2020 · 1 comment
Closed

Levity Affects Spectators #416

Bloo-dev opened this issue May 27, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@Bloo-dev
Copy link
Member

Describe the bug
Levity works on spectators. This means that spectators leave (visible!) cloud trails and get the slow falling effect.

To Reproduce
Steps to reproduce the behavior:

  1. Put on some levity gear
  2. Switch to spectator
  3. Sneak

Expected behavior
Levity should ignore spectators.

Fix
Add a gamemode=!spectator selector.

Environment

  • Minecraft version: 1.15.2
  • Server version: 1.15.2 (Public Server 6)
@Bloo-dev Bloo-dev added the bug Something isn't working label May 27, 2020
@misode
Copy link
Member

misode commented May 27, 2020

This also affects enderpuffs

Bloo-dev added a commit that referenced this issue Jun 1, 2020
@Bloo-dev
Improves Metallurgy's Spectator Handler
bf48967 
This change allows the module to revoke the "gm4_has_shamir" tags from spectators, whilst not allowing these tags to be re-applied onto spectators. This should make sure all base-packaged shamirs only work on non-spectator players, thereby fixing #416 .
Not that this only affects shamirs packaged within the metallurgy base.
@Bloo-dev Bloo-dev mentioned this issue Jun 1, 2020
Merged
Bloo-dev added a commit that referenced this issue Jun 1, 2020
@Bloo-dev
Improves Metallurgy's Spectator Handler (#419)
83e7898 
This change allows the module to revoke the "gm4_has_shamir" tags from spectators, whilst not allowing these tags to be re-applied onto spectators. This should make sure all base-packaged shamirs only work on non-spectator players, thereby fixing #416 .
Not that this only affects shamirs packaged within the metallurgy base.
@Bloo-dev Bloo-dev closed this as completed Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@misode @Bloo-dev