Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-Game Text Appears Broken #864

Closed
Bloo-dev opened this issue Apr 2, 2023 · 1 comment · Fixed by #857
Closed

In-Game Text Appears Broken #864

Bloo-dev opened this issue Apr 2, 2023 · 1 comment · Fixed by #857
Assignees
Labels
bug Something isn't working

Comments

@Bloo-dev
Copy link
Member

Bloo-dev commented Apr 2, 2023

Describe the bug
Most text components introduced by Gamemode 4 (item names, advancement names, item lore, etc.) do not show correctly, instead, a mix of numbers, letters and % is displayed.
To Reproduce
Steps to reproduce the behavior:

  1. Install a Gamemode 4 Datapack.
  2. Open the advancement tree or hover over a Gamemode 4 item.
  3. The text will show as %1s$s%3427655$s or something similar

Expected behavior
Text components should be human-readable.

Fix
This issue is caused by a change Mojang made in 1.19.4 and affects all Datapacks that implement translate keys (i.e. ones that allow resource packs to add translations).
A proper fix will require replacing of all translate components within the affected Datapacks with the new format specified by Mojang, and perhaps a complicated update-functions to update old items, blocks, entites, etc.
PR #857 is currently WIP.

A temporary fix, if applicable, is to stick with 1.19.3

Screenshots
image

Environment

  • Minecraft version: 1.19.4
@Bloo-dev Bloo-dev added the bug Something isn't working label Apr 2, 2023
@misode misode linked a pull request Apr 6, 2023 that will close this issue
@misode
Copy link
Member

misode commented May 29, 2023

Fixed in #867

@misode misode closed this as completed May 29, 2023
@misode misode self-assigned this May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants