Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gamemode 4 Welcome Toast Condition #875

Closed
Bloo-dev opened this issue Jun 5, 2023 · 0 comments · Fixed by #878
Closed

Gamemode 4 Welcome Toast Condition #875

Bloo-dev opened this issue Jun 5, 2023 · 0 comments · Fixed by #878
Labels
fix This fixes something that was wrong

Comments

@Bloo-dev
Copy link
Member

Bloo-dev commented Jun 5, 2023

The Gamemode 4 Welcome Toast (introduced in PR #844) is currently set to only play when the song plays, however, it should play upon first join, not only on Gamemode 4's first install.

This issue is a notice to fix this behavior later on.
@Bloo-dev Bloo-dev added the fix This fixes something that was wrong label Jun 5, 2023
@Bloo-dev Bloo-dev mentioned this issue Jun 8, 2023
Merged
2 tasks
@Bloo-dev Bloo-dev linked a pull request Jun 9, 2023 that will close this issue
Intro Toast Visibility #878
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fix This fixes something that was wrong
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Intro Toast Visibility Bloo-dev/GM4_Datapacks
1 participant
@Bloo-dev