Intro Toast Visibility #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the advancement trigger to 'location' and removes the command-driven granting.
Removes the degeneracy between the Gamemode 4 Root Advancement and the Welcome Toast's titles.
Data Packs
We can still check scores in advancements Additionally I think I would prefer a more friendly message than "this world is using Gamemode 4 Data Packs!". Maybe "Thank you for using Gamemode 4 Data Packs!" |
|
I have updated the toast message and added a load score check to make sure the advancement doesn't grant itself if the base does not load correctly, as is standard with other Gamemode 4 advancements. |
Updates Toast message to be in line with discussion on discord.
github-actions bot
pushed a commit
that referenced
this pull request
Jun 11, 2023
Moves the intro toast to a loaction-triggered advancement, thereby making it appear upon first login for every player, letting them know that Gamemode 4 is installed. Also updates the text of this 'Welcome Toast' to use its own translation key and fallback text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #875.
Moves the intro toast to a loaction-triggered advancement, thereby making it appear upon first login for every player, letting them know that Gamemode 4 is installed. Also updates the text of this 'Welcome Toast' to use its own translation key and fallback text.
Feel free to discuss the specific fallback message below, especially (check if resolved):
impossibletrigger and grant it via functions? The latter would allow for a score-based toggle and/or a score based check instead of relying simple advancement existence.