Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump up node to 20 and fix vulnerabilities #61

Conversation

d-seion
Copy link
Contributor

@d-seion d-seion commented Feb 2, 2024

why

A warning is being displayed from GitHub Actions.

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: slack-workflow-status@master. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

what i did

As title

@d-seion d-seion closed this Feb 2, 2024
@d-seion d-seion deleted the chore/bump_up_node_to_20_and_fix_vulnerabilities branch February 2, 2024 08:44
@rsyvarth
Copy link
Member

rsyvarth commented Feb 2, 2024

Hi @d-seion - is there a reason why you closed this PR? We would love to accept your contribution

@d-seion d-seion restored the chore/bump_up_node_to_20_and_fix_vulnerabilities branch February 2, 2024 08:59
@d-seion
Copy link
Contributor Author

d-seion commented Feb 2, 2024

@rsyvarth
I closed this Pull Request temporarily as it was untested. After conducting tests, I have reopened it, so please review it

@d-seion d-seion reopened this Feb 2, 2024
@AnthonyKinson
Copy link
Member

Looks good!

@AnthonyKinson AnthonyKinson merged commit 68bf00d into Gamesight:master Feb 6, 2024
@d-seion d-seion deleted the chore/bump_up_node_to_20_and_fix_vulnerabilities branch February 6, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants