Skip to content

Commit

Permalink
[CI] Remove carvel change dependencies.
Browse files Browse the repository at this point in the history
  • Loading branch information
corneil committed Sep 10, 2024
1 parent c9c7721 commit 72adc03
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 24 deletions.
4 changes: 0 additions & 4 deletions src/carvel/config/dataflow-deployment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@ apiVersion: apps/v1
kind: Deployment
metadata:
name: scdf-server
annotations:
kapp.k14s.io/change-group: "scdf.tanzu.vmware.com/server"
kapp.k14s.io/change-rule.1: "upsert after upserting scdf.tanzu.vmware.com/db"
kapp.k14s.io/change-rule.2: "upsert after upserting scdf.tanzu.vmware.com/skipper"
labels:
app: scdf-server
spec:
Expand Down
4 changes: 0 additions & 4 deletions src/carvel/config/dataflow-svc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@ kind: Service
apiVersion: v1
metadata:
name: scdf-server
annotations:
kapp.k14s.io/change-group: "scdf.tanzu.vmware.com/server"
kapp.k14s.io/change-rule.1: "upsert after upserting scdf.tanzu.vmware.com/db"
kapp.k14s.io/change-rule.2: "upsert after upserting scdf.tanzu.vmware.com/skipper"
labels:
app: scdf-server
spring-deployment-id: scdf
Expand Down
3 changes: 0 additions & 3 deletions src/carvel/config/skipper-deployment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ apiVersion: apps/v1
kind: Deployment
metadata:
name: skipper
annotations:
kapp.k14s.io/change-group: "scdf.tanzu.vmware.com/skipper"
kapp.k14s.io/change-rule: "upsert after upserting scdf.tanzu.vmware.com/db"
labels:
app: skipper
spec:
Expand Down
3 changes: 0 additions & 3 deletions src/carvel/config/skipper-svc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ apiVersion: v1
kind: Service
metadata:
name: skipper
annotations:
kapp.k14s.io/change-group: "scdf.tanzu.vmware.com/skipper"
kapp.k14s.io/change-rule: "upsert after upserting scdf.tanzu.vmware.com/db"
labels:
app: skipper
spring-deployment-id: scdf
Expand Down
20 changes: 10 additions & 10 deletions src/carvel/test/ordering.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,16 @@ describe('ordering', () => {
const skipperDbService = findService(yaml, DB_SKIPPER_NAME);
const dataflowDbService = findService(yaml, DB_DATAFLOW_NAME);

expect(findAnnotation(skipperService, 'kapp.k14s.io/change-group')).toBe('scdf.tanzu.vmware.com/skipper');
expect(findAnnotation(skipperDeployment, 'kapp.k14s.io/change-group')).toBe('scdf.tanzu.vmware.com/skipper');
expect(findAnnotation(dataflowService, 'kapp.k14s.io/change-group')).toBe('scdf.tanzu.vmware.com/server');
expect(findAnnotation(dataflowDeployment, 'kapp.k14s.io/change-group')).toBe('scdf.tanzu.vmware.com/server');
expect(findAnnotations(dataflowService, 'kapp.k14s.io/change-rule')).toContainAnyValues([
'upsert after upserting scdf.tanzu.vmware.com/skipper'
]);
expect(findAnnotations(dataflowDeployment, 'kapp.k14s.io/change-rule')).toContainAnyValues([
'upsert after upserting scdf.tanzu.vmware.com/skipper'
]);
// expect(findAnnotation(skipperService, 'kapp.k14s.io/change-group')).toBe('scdf.tanzu.vmware.com/skipper');
// expect(findAnnotation(skipperDeployment, 'kapp.k14s.io/change-group')).toBe('scdf.tanzu.vmware.com/skipper');
// expect(findAnnotation(dataflowService, 'kapp.k14s.io/change-group')).toBe('scdf.tanzu.vmware.com/server');
// expect(findAnnotation(dataflowDeployment, 'kapp.k14s.io/change-group')).toBe('scdf.tanzu.vmware.com/server');
// expect(findAnnotations(dataflowService, 'kapp.k14s.io/change-rule')).toContainAnyValues([
// 'upsert after upserting scdf.tanzu.vmware.com/skipper'
// ]);
// expect(findAnnotations(dataflowDeployment, 'kapp.k14s.io/change-rule')).toContainAnyValues([
// 'upsert after upserting scdf.tanzu.vmware.com/skipper'
// ]);
});

it('should have annotation for servers configmap', async () => {
Expand Down

0 comments on commit 72adc03

Please sign in to comment.