Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev/ftp retries #2

Merged
merged 2 commits into from
Nov 27, 2017
Merged

Dev/ftp retries #2

merged 2 commits into from
Nov 27, 2017

Conversation

ASVincent
Copy link
Contributor

  • Adds a retry parameter to the ftp fetch which reconnects the ftp session.
  • Adds additional logging to the ftp sync prior to calling ftp.quit().

jeremyh
jeremyh approved these changes Nov 27, 2017
View reviewed changes
Copy link
Member

@jeremyh jeremyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex.

If the issue persists, it may be worth adding a small delay between retries to better handle any small dropouts.

@ASVincent ASVincent merged commit 95eedbe into GeoscienceAustralia:develop Nov 27, 2017
@ASVincent ASVincent deleted the dev/ftp_retries branch November 27, 2017 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyh jeremyh jeremyh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ASVincent @jeremyh