Use "noImplicitOverride": true as default (openmediavault#1762)

Signed-off-by: Volker Theile <votdev@gmx.de>

deb/openmediavault/workbench/src/app/core/components/intuition/datatable-page/datatable-page.component.ts

@@ -82,7 +82,7 @@ export class DatatablePageComponent extends AbstractPageComponent<DatatablePageC
   /**
    * Append the current selection to the page context.
    */
-  get pageContext(): PageContext {
+  override get pageContext(): PageContext {
     const result = _.merge(
       {
         _selected: this.selection.selected
@@ -351,7 +351,7 @@ export class DatatablePageComponent extends AbstractPageComponent<DatatablePageC
     }
   }
 
-  protected sanitizeConfig() {
+  protected override sanitizeConfig() {
     _.defaultsDeep(this.config, {
       columnMode: 'flex',
       hasActionBar: true,
@@ -409,7 +409,7 @@ export class DatatablePageComponent extends AbstractPageComponent<DatatablePageC
     }
   }
 
-  protected onRouteParams() {
+  protected override onRouteParams() {
     // Format tokenized configuration properties.
     this.formatConfig([
       'title',

deb/openmediavault/workbench/src/app/core/components/intuition/form-page/form-page.component.ts

@@ -111,7 +111,7 @@ export class FormPageComponent
   /**
    * Append the current page mode. This can be editing or creating.
    */
-  get pageContext(): PageContext {
+  override get pageContext(): PageContext {
     return _.merge(
       {
         _editing: this.editing
@@ -120,7 +120,7 @@ export class FormPageComponent
     );
   }
 
-  ngOnInit(): void {
+  override ngOnInit(): void {
     super.ngOnInit();
     // Flatten all form field configurations into an array to be able to
     // iterate over them easily.
@@ -144,7 +144,7 @@ export class FormPageComponent
     });
   }
 
-  ngAfterViewInit(): void {
+  override ngAfterViewInit(): void {
     super.ngAfterViewInit();
     // Process all specified constraints per button.
     if (_.some(this.config.buttons, (button) => _.isPlainObject(button.enabledConstraint))) {
@@ -446,7 +446,7 @@ export class FormPageComponent
     }
   }
 
-  protected sanitizeConfig() {
+  protected override sanitizeConfig() {
     _.defaultsDeep(this.config, {
       buttonAlign: 'end',
       buttons: []
@@ -494,7 +494,7 @@ export class FormPageComponent
     this.config.icon = _.get(Icon, this.config.icon, this.config.icon);
   }
 
-  protected onRouteParams() {
+  protected override onRouteParams() {
     const allFields = flattenFormFieldConfig(this.config.fields);
     // Format tokenized configuration properties.
     this.formatConfig(['title', 'subTitle', 'request.get.method', 'request.get.params']);

deb/openmediavault/workbench/src/app/core/components/intuition/form/components/form-datatable/form-datatable.component.ts

@@ -28,7 +28,7 @@ import { Icon } from '~/app/shared/enum/icon.enum';
   styleUrls: ['./form-datatable.component.scss']
 })
 export class FormDatatableComponent extends AbstractFormFieldComponent {
-  protected sanitizeConfig(): void {
+  protected override sanitizeConfig(): void {
     super.sanitizeConfig();
     if (this.config.hasSearchField || this.config.actions.length) {
       this.config.hasActionBar = true;

deb/openmediavault/workbench/src/app/core/components/intuition/form/components/form-folderbrowser/form-folderbrowser.component.ts

@@ -27,7 +27,6 @@ import { catchError, concatMap, map, startWith, takeUntil, tap, toArray } from '
 
 import { AbstractFormFieldComponent } from '~/app/core/components/intuition/form/components/abstract-form-field-component';
 import { Unsubscribe } from '~/app/decorators';
-import { Icon } from '~/app/shared/enum/icon.enum';
 import { RpcService } from '~/app/shared/services/rpc.service';
 
 @Component({
@@ -45,7 +44,6 @@ export class FormFolderbrowserComponent
   @Unsubscribe()
   private subscriptions = new Subscription();
 
-  icon = Icon;
   isOpen = false;
   folders: string[] = [];
   filteredFolders$: Observable<string[]>;
@@ -83,7 +81,7 @@ export class FormFolderbrowserComponent
     return this.joinPaths(this.currentPaths);
   }
 
-  ngOnInit(): void {
+  override ngOnInit(): void {
     super.ngOnInit();
     this.viewportRuler
       .change()

deb/openmediavault/workbench/src/app/core/components/intuition/form/components/form-select/form-select.component.ts

@@ -40,7 +40,7 @@ export class FormSelectComponent extends AbstractFormFieldComponent implements O
     super();
   }
 
-  ngOnInit(): void {
+  override ngOnInit(): void {
     super.ngOnInit();
     this.doLoadStore();
 

deb/openmediavault/workbench/src/app/core/components/intuition/form/components/form-sharedfolder-select/form-sharedfolder-select.component.ts

@@ -42,7 +42,7 @@ export class FormSharedfolderSelectComponent extends FormSelectComponent {
     });
   }
 
-  protected sanitizeConfig(): void {
+  protected override sanitizeConfig(): void {
     super.sanitizeConfig();
     _.merge(this.config, {
       valueField: 'uuid',

deb/openmediavault/workbench/src/app/core/components/intuition/form/components/form-sshcert-select/form-sshcert-select.component.ts

@@ -41,7 +41,7 @@ export class FormSshcertSelectComponent extends FormSelectComponent {
     });
   }
 
-  protected sanitizeConfig(): void {
+  protected override sanitizeConfig(): void {
     super.sanitizeConfig();
     _.merge(this.config, {
       valueField: 'uuid',

deb/openmediavault/workbench/src/app/core/components/intuition/form/components/form-sslcert-select/form-sslcert-select.component.ts

@@ -41,7 +41,7 @@ export class FormSslcertSelectComponent extends FormSelectComponent {
     });
   }
 
-  protected sanitizeConfig(): void {
+  protected override sanitizeConfig(): void {
     super.sanitizeConfig();
     _.merge(this.config, {
       valueField: 'uuid',

deb/openmediavault/workbench/src/app/core/components/intuition/form/components/form-text-input/form-text-input.component.ts

@@ -47,7 +47,7 @@ export class FormTextInputComponent extends AbstractFormFieldComponent implement
     super();
   }
 
-  ngOnInit(): void {
+  override ngOnInit(): void {
     super.ngOnInit();
     this.abstractControl = this.formGroup.get(this.config.name);
     this.filteredOptions$ = this.abstractControl.valueChanges.pipe(

deb/openmediavault/workbench/src/app/core/components/intuition/rrd-page/rrd-page.component.ts

@@ -70,7 +70,7 @@ export class RrdPageComponent extends AbstractPageComponent<RrdPageConfig> imple
     });
   }
 
-  ngOnInit(): void {
+  override ngOnInit(): void {
     super.ngOnInit();
     this.time = unixTimeStamp();
     if (this.config?.store) {

deb/openmediavault/workbench/src/app/core/components/intuition/selection-list-page/selection-list-page.component.ts

@@ -64,7 +64,7 @@ export class SelectionListPageComponent
     super(activatedRoute, authSessionService, router);
   }
 
-  ngOnInit(): void {
+  override ngOnInit(): void {
     super.ngOnInit();
     this.loadData();
   }
@@ -156,7 +156,7 @@ export class SelectionListPageComponent
       });
   }
 
-  protected sanitizeConfig() {
+  protected override sanitizeConfig() {
     _.defaultsDeep(this.config, {
       hasSelectAllButton: false,
       buttonAlign: 'end',

deb/openmediavault/workbench/src/app/core/components/intuition/tabs-page/tabs-page.component.ts

@@ -40,7 +40,7 @@ export class TabsPageComponent extends AbstractPageComponent<TabsPageConfig> {
     super(activatedRoute, authSessionService, router);
   }
 
-  protected sanitizeConfig() {
+  protected override sanitizeConfig() {
     _.defaultsDeep(this.config, {
       singleRoute: true,
       tabs: []

deb/openmediavault/workbench/src/app/core/components/intuition/text-page/text-page.component.ts

@@ -62,7 +62,7 @@ export class TextPageComponent
     super(activatedRoute, authSessionService, router);
   }
 
-  ngOnInit(): void {
+  override ngOnInit(): void {
     super.ngOnInit();
     this.reloadSubscription = timer(
       0,
@@ -72,7 +72,7 @@ export class TextPageComponent
     });
   }
 
-  ngOnDestroy(): void {
+  override ngOnDestroy(): void {
     this.reloadSubscription?.unsubscribe();
     super.ngOnDestroy();
   }
@@ -117,7 +117,7 @@ export class TextPageComponent
     }
   }
 
-  protected sanitizeConfig() {
+  protected override sanitizeConfig() {
     _.defaultsDeep(this.config, {
       autoReload: false,
       hasReloadButton: false,
@@ -143,7 +143,7 @@ export class TextPageComponent
     });
   }
 
-  protected onRouteParams() {
+  protected override onRouteParams() {
     // Format tokenized configuration properties.
     this.formatConfig(['title', 'subTitle', 'request.get.method', 'request.get.params']);
   }

deb/openmediavault/workbench/tsconfig.json

@@ -13,6 +13,7 @@
     "noUnusedLocals": true,
     "noUnusedParameters": false,
     "noFallthroughCasesInSwitch": true,
+    "noImplicitOverride": true,
     "noImplicitThis": true,
     "noImplicitReturns": true,
     "noImplicitAny": false,