Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

Add contribution guidelines #33

Merged
merged 1 commit into from
Jul 17, 2018
Merged

Add contribution guidelines #33

merged 1 commit into from
Jul 17, 2018

Conversation

rodrigobdz
Copy link
Contributor

@rodrigobdz rodrigobdz commented Jul 17, 2018

Fixes #30. This should be merged when #28 is closed and #32 is merged. Otherwise there will be broken links.

The contribution guidelines are based on Facebook's React Native, Microsoft's VS Code and Shakacode's React on Rails CONTRIBUTING.md.

@rodrigobdz
Copy link
Contributor Author

The CI tests are failing due to a network timeout.
Travis CI error.

@rodrigobdz rodrigobdz self-assigned this Jul 17, 2018
@cosmocochrane1
Copy link
Contributor

@rodrigobdz we should really be faking the network request to prevent this from happening - but its helpful to have the real request as the API occasionally changes. - We can go ahead and just merge this

Copy link
Contributor

@cosmocochrane1 cosmocochrane1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@cosmocochrane1 cosmocochrane1 merged commit 8cdaaf8 into Giphy:master Jul 17, 2018
@rodrigobdz rodrigobdz deleted the patch-3 branch July 17, 2018 19:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing contribution guidelines
2 participants