Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/render-highlight #47

Merged
merged 6 commits into from
Aug 4, 2018

Conversation

kylelol
Copy link
Collaborator

@kylelol kylelol commented Jul 20, 2018

Implemented a way to always have the highlight view always present around a range of text, instead of just having to tap on the text to get it to appear.

@kylelol
Copy link
Collaborator Author

kylelol commented Jul 23, 2018

@rnystrom is this good to merge? Just wanted to double check.

@rnystrom
Copy link
Member

@kylelol hey sorry I keep forgetting to come back to this. I need to go through this in a little more detail to make sure nothing regresses. Im a little unsure about the new layers and layout calls in the view.

Sent with GitHawk

@kylelol
Copy link
Collaborator Author

kylelol commented Jul 27, 2018

@rnystrom Sounds good. I think we can probably do without the reposition call in layoutSubviews and rely the implementer to add that in manually.

The extra layer stuff was just to put the highlight behind the text instead of overtop of it.

@rnystrom
Copy link
Member

@kylelol if we can do w/out the layout call, let's roll w/ that. We can add it in if it becomes a burden/issue

@kylelol
Copy link
Collaborator Author

kylelol commented Jul 31, 2018

@rnystrom it's removed. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants