-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement/render-highlight #47
Improvement/render-highlight #47
Conversation
…always highlighted state
… to re-highlight on layout pass.
66e61b5
to
1271289
Compare
@rnystrom is this good to merge? Just wanted to double check. |
@rnystrom Sounds good. I think we can probably do without the reposition call in The extra layer stuff was just to put the highlight behind the text instead of overtop of it. |
@kylelol if we can do w/out the layout call, let's roll w/ that. We can add it in if it becomes a burden/issue |
@rnystrom it's removed. 👍 |
Implemented a way to always have the highlight view always present around a range of text, instead of just having to tap on the text to get it to appear.