-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
npm: bump eslint from 8.57.0 to 9.1.1 #3829
Conversation
26f72bc
to
aba0f1c
Compare
Bumps [eslint](https://github.com/eslint/eslint) from 8.57.0 to 9.1.1. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.57.0...v9.1.1) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
aba0f1c
to
e28bf5a
Compare
@jyasskin @jcscottiii Does my config migration look reasonable? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one nit and one question
eslint.config.js
Outdated
@@ -0,0 +1,53 @@ | |||
import js from "@eslint/js"; | |||
import prettier from "./node_modules/eslint-config-prettier/prettier.js"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
I know we import straight from node_modules for gts, we may be able to use the named import instead of the path import for prettier though.
Additionally, we should use eslintConfigPrettier
https://github.com/prettier/eslint-config-prettier?tab=readme-ov-file#installation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I think I followed the example from that link.
js.configs.recommended, | ||
prettier, | ||
{ | ||
rules: gts.rules, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried to see if these rules are working? I see these issues:
google/gts#847 (comment)
google/gts#830
I don't think anything is stopping us from using the flat config but I couldn't find any examples of gts being configured in the flat config format. So I figured I would ask.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it seems to work. E.g., it complains if I mess up the formatting or have any unused variable.
Bumps eslint from 8.57.0 to 9.1.1.
Release notes
Sourced from eslint's releases.
... (truncated)
Changelog
Sourced from eslint's changelog.
... (truncated)
Commits
b4d2512
9.1.1ef36aa4
Build: changelog update for 9.1.1a26b402
fix: use@eslint/create-config
latest (#18373)b78d831
9.1.0e4d9c92
Build: changelog update for 9.1.0d9a2983
chore: upgrade@eslint/js
to v9.1.1 (#18367)03068f1
feat: Provide helpful error message for nullish configs (#18357)50d406d
chore: package.json update for@eslint/js
release8d18958
fix: Remove name from eslint/js packages (#18368)155c71c
chore: package.json update for@eslint/js
releaseDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)