deps(raven): make raven an optional peer dependency #13020
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remcohaszing
changed the title
remcohaszing
changed the title
This package has been deprecated in favor of `@sentry/node`. It just hasn’t been marked as such on npmjs.com. It depends on deprecated packages, which yields deprecation warnings for users installing lighthouse. It’s usage is optional in lighthouse. It’s disabled by default, and even if it’s enabled in options, the `require` statement for it is in a try-catch block.
|
As this is our error reporting service, we can't expect users to manually install it for us to continue to receive error reports, so we can't accept this PR. Are you aware of other projects installing this package on an as-needed basis? We do have this PR I started but abandoned due to prioritization: #9325 |
|
I was under the impression error reporting was disabled by default, but I was wrong. The user is prompted for explicit consent. lighthouse/lighthouse-cli/bin.js Lines 132 to 134 in 26a0ee6 Personally I was a bit triggered by the deprecation messages displayed when running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This package has been deprecated in favor of
@sentry/node. It just hasn’t been marked as such on npmjs.com.It depends on deprecated packages, which yields deprecation warnings for users installing lighthouse.
It’s usage is optional in lighthouse. It’s disabled by default, and even if it’s enabled in options, the
requirestatement for it is in a try-catch block.Related Issues/PRs
https://docs.sentry.io/clients/javascript/