Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clients: convert extension to ES modules #14181

Merged
merged 1 commit into from
Jun 30, 2022
Merged

clients: convert extension to ES modules #14181

merged 1 commit into from
Jun 30, 2022

Conversation

connorjclark
Copy link
Collaborator

ref #12689

@connorjclark connorjclark requested a review from a team as a code owner June 30, 2022 22:32
@connorjclark connorjclark requested review from adamraine and removed request for a team June 30, 2022 22:32
adamraine
adamraine approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@adamraine adamraine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we remove the package.json in clients/devtools now too?

@connorjclark
Copy link
Collaborator Author

Of course, but I'm just gonna do all that later... don't want to pay the CI time tax just for that 👀

@connorjclark connorjclark merged commit 53a4e3d into master Jun 30, 2022
@connorjclark connorjclark deleted the ext-esm branch June 30, 2022 23:15
@connorjclark connorjclark mentioned this pull request Jul 1, 2022
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamraine adamraine adamraine approved these changes

Assignees

@adamraine adamraine

Labels
waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connorjclark @adamraine @devtools-bot