Expand report <details> on print. Fixes #1240 #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FINALLY |
| @@ -45,7 +45,32 @@ function sendJSONReport() { | |||
| const popup = window.open(VIEWER_URL, '_blank'); | |||
| } | |||
|
|
|||
| /** | |||
| * Sets up listeners to expand audit `<details>` when the user prints the page. | |||
There was a problem hiding this comment.
this is kind of dumb, but maybe add a clause here that expanding <details> isn't possible via a print stylesheet? Whenever I think about this issue my first thought is always, "wait, why can't we just solve this in the print stylesheet?" and it probably will be again when I come across this function in the future :)
|
viewer doesn't inherit this, right? Should it? |
It will :) |
|
Wow. The cross browser subtleties in this one are fascinating! Nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: all
The people have spoken. They want better printing!