simplifying validation of isolation level

GoogleCloudPlatform · Oct 25, 2023 · 0bbca1c · 0bbca1c
1 parent 45673cf
commit 0bbca1c
Showing 1 changed file with 4 additions and 16 deletions.
diff --git a/...r2dbc/src/main/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryConnection.java b/...r2dbc/src/main/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryConnection.java
@@ -18,13 +18,10 @@
 
 import static com.google.cloud.spanner.r2dbc.v2.SpannerConstants.TIMESTAMP_BOUND;
 import static com.google.common.base.MoreObjects.firstNonNull;
-import static io.r2dbc.spi.IsolationLevel.READ_COMMITTED;
-import static io.r2dbc.spi.IsolationLevel.READ_UNCOMMITTED;
-import static io.r2dbc.spi.IsolationLevel.REPEATABLE_READ;
+import static io.r2dbc.spi.IsolationLevel.SERIALIZABLE;
 import static io.r2dbc.spi.TransactionDefinition.ISOLATION_LEVEL;
 import static io.r2dbc.spi.TransactionDefinition.READ_ONLY;
 import static java.lang.Boolean.TRUE;
-import static java.util.Arrays.asList;
 
 import com.google.cloud.spanner.TimestampBound;
 import com.google.cloud.spanner.r2dbc.api.SpannerConnection;
@@ -38,16 +35,11 @@
 import io.r2dbc.spi.TransactionDefinition;
 import io.r2dbc.spi.ValidationDepth;
 import java.time.Duration;
-import java.util.List;
 import org.reactivestreams.Publisher;
 import reactor.core.publisher.Mono;
 
 class SpannerClientLibraryConnection implements Connection, SpannerConnection {
 
-  private static final List<IsolationLevel> UNSUPPORTED_ISOLATION_LEVELS = asList(READ_COMMITTED,
-      READ_UNCOMMITTED,
-      REPEATABLE_READ);
-
   private final DatabaseClientReactiveAdapter clientLibraryAdapter;
 
   /**
@@ -190,12 +182,8 @@ public boolean isInReadonlyTransaction() {
   }
 
   private Mono<Void> validateIsolation(IsolationLevel isolationLevel) {
-    boolean invalid =
-        isolationLevel != null && UNSUPPORTED_ISOLATION_LEVELS.contains(isolationLevel);
-    if (invalid) {
-      return Mono.error(new UnsupportedOperationException(
-          String.format("'%s' isolation level not supported", isolationLevel.asSql())));
-    }
-    return Mono.empty();
+    boolean valid = isolationLevel == null || isolationLevel == SERIALIZABLE;
+    return valid ? Mono.empty(): Mono.error(new UnsupportedOperationException(
+        String.format("'%s' isolation level not supported", isolationLevel.asSql())));
   }
 }