feat: Implementing Connection#beginTransaction(TransactionDefinition) to support @Transactional annotation #738
Conversation
cloud-spanner-r2dbc/src/main/java/com/google/cloud/spanner/r2dbc/v2/SpannerConstants.java
Outdated
Show resolved
Hide resolved
...er-r2dbc/src/main/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryConnection.java
Outdated
Show resolved
Hide resolved
...2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryConnectionTest.java
Outdated
Show resolved
Hide resolved
...er-r2dbc/src/main/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryConnection.java
Outdated
Show resolved
Hide resolved
| @@ -51,7 +66,16 @@ public Publisher<Void> beginTransaction() { | |||
|
|
|||
| @Override | |||
| public Publisher<Void> beginTransaction(TransactionDefinition definition) { | |||
| return Mono.error(new UnsupportedOperationException()); | |||
| return validateIsolation(definition.getAttribute(ISOLATION_LEVEL)) | |||
There was a problem hiding this comment.
Partially yes,
#238 talks about read-only, read-write, stale-read and partitioned DML. Out of these first three are supported but not partitioned DML but that is not supported by the driver itself.
There was a problem hiding this comment.
Can we create a separate issue for DML support, and close #238 as part of this PR?
...er-r2dbc/src/main/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryConnection.java
Show resolved
Hide resolved
...er-r2dbc/src/main/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryConnection.java
Outdated
Show resolved
Hide resolved
...er-r2dbc/src/main/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryConnection.java
Outdated
Show resolved
Hide resolved
...er-r2dbc/src/main/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryConnection.java
Outdated
Show resolved
Hide resolved
...2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryConnectionTest.java
Outdated
Show resolved
Hide resolved
...er-r2dbc/src/main/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryConnection.java
Show resolved
Hide resolved
| this.internalMap = internalMap; | ||
| } | ||
|
|
||
| private void validate(Map<Option<?>, Object> internalMap) { | ||
| if (FALSE.equals(internalMap.get(READ_ONLY)) && internalMap.containsKey(TIMESTAMP_BOUND)) { |
There was a problem hiding this comment.
What happens if the user has not set any value for READ_ONLY? The default is then read/write, and the TIMESTAMP_BOUND will be ignored. So should the test not also include a check whether there is no READ_ONLY option?
(And maybe centralize that in a single, simple method named something like isReadOnlyTransaction()
There was a problem hiding this comment.
My bad 😓 , fixed that too now.
|
Kudos, SonarCloud Quality Gate passed!
|
Implemented the following classes and methods to conform to R2DBC SPI which enables supporting
@Transactionalannotation in Spring Data Dialect.Connection#beginTransaction(TransactionDefinition)method so that it can be used by aTransactionManagerwhen@Transactionalannotation is used. ✅Connection#getTransactionIsolationLevelreturns SERIALIZABLE as it is the closest level to EXTERNAL_CONSISTENCY which spanner supports. ✅Connection#setTransactionIsolationLevel(IsolationLevel)accepts onlyIsolationLevel.SERIALIZABLEand throwUnsupportedOperationExceptionotherwise. ✅SpannerTransactionDefinition, an implementation ofTransactionDefinition(R2DBC spi) to configure the transaction attributes which will be used byConnection#beginTransaction(TransactionDefinition)method. ✅Fixes #238