Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jdbc/mysql-j-8): Add native image support for jdbc/mysql-j-8 #966

Merged
merged 9 commits into from
Sep 8, 2022

Conversation

mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Aug 31, 2022

Part of #824

@mpeddada1 mpeddada1 changed the title fix(jdbc/mysql-j-5): testing native image support for jdbc/mysql-j-5 … fix(jdbc/mysql-j-8): testing native image support for jdbc/mysql-j-5 … Sep 2, 2022
@mpeddada1
Copy link
Contributor Author

Enabling mysql-j-8 results in the following error:

Failures (1):
  JUnit Vintage:JdbcMysqlJ8IntegrationTests:pooledConnectionTest
    MethodSource [className = 'com.google.cloud.sql.mysql.JdbcMysqlJ8IntegrationTests', methodName = 'pooledConnectionTest', methodParameterTypes = '']
    => org.opentest4j.MultipleFailuresError: Multiple Failures (2 failures)
	com.zaxxer.hikari.pool.HikariPool$PoolInitializationException: Failed to initialize pool: Could not create connection to database server.
	java.lang.NullPointerException: <no message>
       org.junit.vintage.engine.execution.TestRun.getStoredResultOrSuccessful(TestRun.java:200)
       org.junit.vintage.engine.execution.RunListenerAdapter.fireExecutionFinished(RunListenerAdapter.java:248)
       org.junit.vintage.engine.execution.RunListenerAdapter.testFinished(RunListenerAdapter.java:214)
       org.junit.vintage.engine.execution.RunListenerAdapter.testFinished(RunListenerAdapter.java:88)
       org.junit.runner.notification.SynchronizedRunListener.testFinished(SynchronizedRunListener.java:87)
       [...]
       Suppressed: com.zaxxer.hikari.pool.HikariPool$PoolInitializationException: Failed to initialize pool: Could not create connection to database server.
         com.zaxxer.hikari.pool.HikariPool.throwPoolInitializationException(HikariPool.java:596)
         com.zaxxer.hikari.pool.HikariPool.checkFailFast(HikariPool.java:582)
         com.zaxxer.hikari.pool.HikariPool.<init>(HikariPool.java:115)
         com.zaxxer.hikari.HikariDataSource.<init>(HikariDataSource.java:81)
         com.google.cloud.sql.mysql.JdbcMysqlJ8IntegrationTests.setUpPool(JdbcMysqlJ8IntegrationTests.java:85)
         [...]
       Caused by: java.sql.SQLNonTransientConnectionException: Could not create connection to database server.
         com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:110)
         com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:97)
         com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:89)
         com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:63)
         com.mysql.cj.jdbc.ConnectionImpl.connectOneTryOnly(ConnectionImpl.java:1000)
         [...]
       Caused by: java.lang.NullPointerException: inStream parameter is null
         java.util.Objects.requireNonNull(Objects.java:246)
         java.util.Properties.load(Properties.java:406)
         com.mysql.cj.util.TimeUtil.loadTimeZoneMappings(TimeUtil.java:226)
         com.mysql.cj.util.TimeUtil.getCanonicalTimezone(TimeUtil.java:123)
         com.mysql.cj.protocol.a.NativeProtocol.configureTimezone(NativeProtocol.java:2139)
         [...]
       Suppressed: java.lang.NullPointerException
         com.google.cloud.sql.mysql.JdbcMysqlJ8IntegrationTests.dropTableIfPresent(JdbcMysqlJ8IntegrationTests.java:103)
         java.lang.reflect.Method.invoke(Method.java:566)
         org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
         org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
         org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
         [...]

Test run finished after 3201 ms
[         3 containers found      ]
[         0 containers skipped    ]
[         3 containers started    ]
[         0 containers aborted    ]
[         3 containers successful ]
[         0 containers failed     ]
[         1 tests found           ]
[         0 tests skipped         ]
[         1 tests started         ]
[         0 tests aborted         ]
[         0 tests successful      ]
[         1 tests failed          ]

@mpeddada1 mpeddada1 changed the title fix(jdbc/mysql-j-8): testing native image support for jdbc/mysql-j-5 … fix(jdbc/mysql-j-8): testing native image support for jdbc/mysql-j-8 … Sep 2, 2022
@mpeddada1 mpeddada1 changed the title fix(jdbc/mysql-j-8): testing native image support for jdbc/mysql-j-8 … fix(jdbc/mysql-j-8): Add native image support for jdbc/mysql-j-8 Sep 6, 2022
@mpeddada1 mpeddada1 marked this pull request as ready for review September 6, 2022 20:16
@mpeddada1 mpeddada1 requested a review from a team September 6, 2022 20:16
@kurtisvg kurtisvg changed the title fix(jdbc/mysql-j-8): Add native image support for jdbc/mysql-j-8 feat(jdbc/mysql-j-8): Add native image support for jdbc/mysql-j-8 Sep 6, 2022
@shubha-rajan shubha-rajan added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 8, 2022
@shubha-rajan shubha-rajan merged commit 15e01f4 into GoogleCloudPlatform:main Sep 8, 2022
@shubha-rajan shubha-rajan removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants