-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(runjob): add support for cloud_sql_instance #1688
Merged
google-oss-prow
merged 8 commits into
GoogleCloudPlatform:master
from
CyberHippo:feat/run-job-sql-instances
Aug 6, 2024
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
80b9f16
feat(runjob): add sqlinstance tfref in servicemappings
CyberHippo 21e7fb1
feat(runjob): add samples with sqlinstance
CyberHippo e33a047
feat(runjob): add sqlinstance in CRD
CyberHippo caf1447
fix(runjob): sqlinstance ref path
CyberHippo 8b11ca1
feat(runjob): add auto-generated resources
CyberHippo f13a8de
feat(runjob): add dynamic tests
CyberHippo 249d217
feat(runjob): renaming instances to instanceRefs
CyberHippo 26dbc18
fix(runjob): rename instances to instanceRefs in CRD
CyberHippo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
config/samples/resources/runjob/job-with-sql/run_v1beta1_runjob.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
# Copyright 2023 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
apiVersion: run.cnrm.cloud.google.com/v1beta1 | ||
kind: RunJob | ||
metadata: | ||
name: runjob-sample-sql | ||
spec: | ||
launchStage: "GA" | ||
location: "us-central1" | ||
projectRef: | ||
external: ${PROJECT_ID?} | ||
template: | ||
template: | ||
containers: | ||
- image: "us-docker.pkg.dev/cloudrun/container/hello" | ||
volumeMounts: | ||
- name: "cloudsql" | ||
mountPath: "/cloudsql" | ||
volumes: | ||
- name: "cloudsql" | ||
cloudSqlInstance: | ||
instanceRefs: | ||
- name: runjob-dep-sql | ||
lifecycle: | ||
ignore_changes: | ||
- launch_stage |
23 changes: 23 additions & 0 deletions
23
config/samples/resources/runjob/job-with-sql/sql_v1beta1_sqlinstance.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
# Copyright 2022 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
apiVersion: sql.cnrm.cloud.google.com/v1beta1 | ||
kind: SQLInstance | ||
metadata: | ||
name: runjob-dep-sql | ||
spec: | ||
region: us-central1 | ||
databaseVersion: MYSQL_5_7 | ||
settings: | ||
tier: db-n1-standard-1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
26 changes: 26 additions & 0 deletions
26
pkg/clients/generated/apis/run/v1beta1/zz_generated.deepcopy.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
35 changes: 35 additions & 0 deletions
35
pkg/test/resourcefixture/testdata/basic/run/v1beta1/runjob/runjobsql/create.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
# Copyright 2023 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
apiVersion: run.cnrm.cloud.google.com/v1beta1 | ||
kind: RunJob | ||
metadata: | ||
name: runjob-${uniqueId} | ||
spec: | ||
launchStage: "GA" | ||
location: "us-central1" | ||
projectRef: | ||
external: "${projectId}" | ||
template: | ||
template: | ||
volumes: | ||
- name: "cloudsql" | ||
cloudSqlInstance: | ||
instanceRefs: | ||
- name: sqlinstance-1-${uniqueId} | ||
containers: | ||
- image: "us-docker.pkg.dev/cloudrun/container/hello" | ||
volumeMounts: | ||
- name: "cloudsql" | ||
mountPath: "/cloudsql" |
33 changes: 33 additions & 0 deletions
33
pkg/test/resourcefixture/testdata/basic/run/v1beta1/runjob/runjobsql/dependencies.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
# Copyright 2022 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
apiVersion: sql.cnrm.cloud.google.com/v1beta1 | ||
kind: SQLInstance | ||
metadata: | ||
name: sqlinstance-1-${uniqueId} | ||
spec: | ||
region: us-central1 | ||
databaseVersion: MYSQL_5_7 | ||
settings: | ||
tier: db-n1-standard-1 | ||
--- | ||
apiVersion: sql.cnrm.cloud.google.com/v1beta1 | ||
kind: SQLInstance | ||
metadata: | ||
name: sqlinstance-2-${uniqueId} | ||
spec: | ||
region: us-central1 | ||
databaseVersion: MYSQL_5_7 | ||
settings: | ||
tier: db-n1-standard-1 |
37 changes: 37 additions & 0 deletions
37
pkg/test/resourcefixture/testdata/basic/run/v1beta1/runjob/runjobsql/update.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
# Copyright 2023 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
apiVersion: run.cnrm.cloud.google.com/v1beta1 | ||
kind: RunJob | ||
metadata: | ||
name: runjob-${uniqueId} | ||
spec: | ||
launchStage: "GA" | ||
location: "us-central1" | ||
projectRef: | ||
external: "${projectId}" | ||
template: | ||
template: | ||
volumes: | ||
- name: "cloudsql" | ||
cloudSqlInstance: | ||
instanceRefs: | ||
- name: sqlinstance-1-${uniqueId} | ||
- name: sqlinstance-2-${uniqueId} | ||
containers: | ||
- name: "container-name" | ||
image: "us-docker.pkg.dev/cloudrun/container/hello" | ||
volumeMounts: | ||
- name: "cloudsql" | ||
mountPath: "/cloudsql-new-path" |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC this file is generated and field name should be updated to
instanceRefs
as well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I missed it running
make manifests
, fixed with 26dbc18