Use 'Absent' as the default state-into-spec behavior #2432
+251
−1,488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/approve PR looks good. Can you fix the presubmit tests and then I think this is ready to go in? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
maqiuyujoyce
force-pushed
the
202408-make-absent-default
branch
8 times, most recently
from
8406b94
to
31b6f75
Compare
maqiuyujoyce
force-pushed
the
202408-make-absent-default
branch
from
31b6f75
to
671e2d8
Compare
maqiuyujoyce
force-pushed
the
202408-make-absent-default
branch
from
671e2d8
to
4ae97f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Use 'Absent' as the default state-into-spec behavior.
Diff base is #2504.
This PR should NOT be merged before 1.122 is released.
Tests you have done
make ready-prto ensure this PR is ready for review.Built locally and verified that
absentis the default value for state-into-spec annotation when it is not set. And with the cluster-level and namespace-level override, the default value can be rolled back tomerge.