mocks: Update ComputeForwardingRule mock responses with API default fields #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
gemmahou
changed the title
gemmahou
changed the title
gemmahou
force-pushed
the
forwardingrulemock
branch
3 times, most recently
from
442fc9e
to
2c48403
Compare
gemmahou
force-pushed
the
forwardingrulemock
branch
3 times, most recently
from
4e7f740
to
76f8dc9
Compare
justinsb
approved these changes
Aug 13, 2024
|
Thanks @gemmahou ... LGTM (assuming it passes tests!) |
gemmahou
force-pushed
the
forwardingrulemock
branch
from
76f8dc9
to
0870f9d
Compare
|
/lgtm |
gemmahou
force-pushed
the
forwardingrulemock
branch
from
3aef3c5
to
0870f9d
Compare
gemmahou
force-pushed
the
forwardingrulemock
branch
from
0870f9d
to
0ae2dc1
Compare
justinsb
approved these changes
Aug 13, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 9b204cb
into
GoogleCloudPlatform:master
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Comparing with realGCP logs, there are something I missed in the mock:
the current mock is missing some fields, which appear to be API defaulted if unspecified by user(but I do not find any compute documentation mentioning those default values, that's a bit concerning): LabelFingerprint, Fingerprint, IPProtocol, NetworkTier.
if only one number is provided for portRange, i.e. 80, it will be changed to "80-80" as per the realGCP log
Tests you have done
make ready-prto ensure this PR is ready for review.