-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mockgcp support for RedisCluster #2445
Merged
google-oss-prow
merged 3 commits into
GoogleCloudPlatform:master
from
justinsb:rediscluster_mockgcp
Aug 14, 2024
Merged
mockgcp support for RedisCluster #2445
google-oss-prow
merged 3 commits into
GoogleCloudPlatform:master
from
justinsb:rediscluster_mockgcp
Aug 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
justinsb
commented
Aug 8, 2024
- feat: direct controller for RedisCluster
- mockgcp: generate redis cluster proto/grpc
- mockgcp: support for RedisCluster
3edb428
to
6c9fc8b
Compare
6c9fc8b
to
e553678
Compare
e553678
to
cb88a7b
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cb88a7b
to
0b2e15e
Compare
0b2e15e
to
ffab4a7
Compare
2 tasks
/lgtm |
30e6820
into
GoogleCloudPlatform:master
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.