-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:add a label for kcc resource type #2452
Conversation
0220667
to
267dc65
Compare
27d016f
to
6a2c7a0
Compare
Do we want to add the Kind name in the KCC metadata labels as well? This is a duplicate of the |
6a2c7a0
to
091de68
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
091de68
to
165dcc7
Compare
Yeah, can you describe more what we're trying to achieve here. AIUI the GCP resource implies the KCC resource, so I'm not sure what we're adding? We have the |
Essentially I would like to have a label in concord usage tables that helps me attribute the resource usage to the exact KCC resource. In order to concord to be able to get this information, we first need a label in KCC so that I can later add a label in concord with this information. |
So I am adding this label to pass this information to concord usage tables, not sure if KCC metadata label is needed or can do the same? |
577c50b
to
a603d52
Compare
8691a99
to
c408b97
Compare
c408b97
to
5318411
Compare
Seems like some types (Eg CloudSQLInstance) are not being labelled today. |
Otherwise looks good. |
4551a15
to
5318411
Compare
This PR adds a default label to KCC resource object specifying the resource type.
I would like to have a label in concord usage tables that helps me attribute the resource usage to the exact KCC resource. In order to concord to be able to get this information, we first need a label in KCC so that I can later add a label in concord with this information.