-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: temporarily skip integration tests for edgecontainer #2455
fix: temporarily skip integration tests for edgecontainer #2455
Conversation
pkg/test/constants/constants.go
Outdated
// Creating Remote Control Plane Clusters is no longer supported. | ||
// Need to allowlist test project to bypass this. | ||
// Playbook: https://g3doc.corp.google.com/cloud/verticals/edge/g3doc/cluster_oncall_rotation.md?cl=head#creating-remote-control-plane-clusters-is-no-longer-supported | ||
".*(edgecontainercluster).*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice you beat me to it 💯 ; thanks for adding this 🏅
Let's not link the g3doc here for now. We can create an internal issue to allow list the test project.
pkg/test/constants/constants.go
Outdated
@@ -46,6 +50,13 @@ var TestNameRegexesToSkip = []string{ | |||
// Disable due to TF bug https://github.com/hashicorp/terraform-provider-google/issues/16255. | |||
// We can't specify labels in the create operation, that causes AssertLabelsMatchAndHaveManagedLabel check to fail. | |||
".*(regionalforwardingrulepsc).*", | |||
// Tests added for sci-fi direct controller is temporarily disabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I'm slightly concerned that we may lose actual good signal about the direct resources. Can we consider just disabling the export part of the tests for this if it's easy to do ?
Game to do that as a follow on and just ignore for now but would love to hear from Yuwen too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, thinking about the same!
I'll remove this part for now as we need more discussion, will focus on edgecontainer test only in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acpana The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
48d3196
into
GoogleCloudPlatform:master
Change description
edgecontainer: test failed due to API change, chatted with API team to skip it for now
Tests you have done
make ready-pr
to ensure this PR is ready for review.