fix: temporarily skip integration tests for edgecontainer #2455
Conversation
gemmahou
changed the title
pkg/test/constants/constants.go
Outdated
| // Creating Remote Control Plane Clusters is no longer supported. | ||
| // Need to allowlist test project to bypass this. | ||
| // Playbook: https://g3doc.corp.google.com/cloud/verticals/edge/g3doc/cluster_oncall_rotation.md?cl=head#creating-remote-control-plane-clusters-is-no-longer-supported | ||
| ".*(edgecontainercluster).*", |
There was a problem hiding this comment.
Nice you beat me to it 💯 ; thanks for adding this 🏅
Let's not link the g3doc here for now. We can create an internal issue to allow list the test project.
pkg/test/constants/constants.go
Outdated
| @@ -46,6 +50,13 @@ var TestNameRegexesToSkip = []string{ | |||
| // Disable due to TF bug https://github.com/hashicorp/terraform-provider-google/issues/16255. | |||
| // We can't specify labels in the create operation, that causes AssertLabelsMatchAndHaveManagedLabel check to fail. | |||
| ".*(regionalforwardingrulepsc).*", | |||
| // Tests added for sci-fi direct controller is temporarily disabled. | |||
There was a problem hiding this comment.
Hm, I'm slightly concerned that we may lose actual good signal about the direct resources. Can we consider just disabling the export part of the tests for this if it's easy to do ?
Game to do that as a follow on and just ignore for now but would love to hear from Yuwen too.
There was a problem hiding this comment.
+1, thinking about the same!
I'll remove this part for now as we need more discussion, will focus on edgecontainer test only in this PR.
gemmahou
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acpana The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 48d3196
into
GoogleCloudPlatform:master
Change description
edgecontainer: test failed due to API change, chatted with API team to skip it for now
Tests you have done
make ready-prto ensure this PR is ready for review.