Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mockgcp: support for MonitoringGroup #2472

Merged

Conversation

justinsb
Copy link
Collaborator

No description provided.

@justinsb justinsb force-pushed the mockgcp_monitoringgroup branch 3 times, most recently from 5446748 to 66d043d Compare August 11, 2024 14:18
@justinsb justinsb force-pushed the mockgcp_monitoringgroup branch 2 times, most recently from deb1d75 to f368846 Compare August 14, 2024 15:19
Copy link
Collaborator

@yuwenma yuwenma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 9421614 into GoogleCloudPlatform:master Aug 14, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants