feat: direct controller for SecureSourceManagerInstance #2478
Conversation
justinsb
commented
Aug 12, 2024
justinsb
commented
- feat: direct controller for SecureSourceManagerInstance
- tests: add basic test for SecureSourceManagerInstance
justinsb
force-pushed
the
securesourcemanagerinstance_controller
branch
from
588a7b6
to
6d838c6
Compare
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
| ) | ||
|
|
||
| func normalizeResourceName(ctx context.Context, reader client.Reader, src client.Object, ref *v1alpha1.ResourceRef) (*v1alpha1.ResourceRef, error) { |
There was a problem hiding this comment.
This is moved from monitoring. My plan is to put it into a shared place, then remove duplicates / refactor etc. Open to alternative suggestions!
| "reflect" | ||
| ) | ||
|
|
||
| type Visitor interface { |
There was a problem hiding this comment.
Also moved from monitoring
justinsb
force-pushed
the
securesourcemanagerinstance_controller
branch
2 times, most recently
from
1c163ea
to
41e5f28
Compare
justinsb
force-pushed
the
securesourcemanagerinstance_controller
branch
from
301efe3
to
2cf1758
Compare
| "k8s.io/apimachinery/pkg/runtime" | ||
| ) | ||
|
|
||
| func SetObservedState(u *unstructured.Unstructured, typedObservedState any) error { |
There was a problem hiding this comment.
Can you add a comment to introduce how we shall (and shall not) use this function?
| type instanceAdapter struct { | ||
| projectID string | ||
| location string | ||
| resourceID string |
There was a problem hiding this comment.
Mind adding a todo about using externalRef instead of the resourceID? Just in case we forget it.
There was a problem hiding this comment.
oh, because https://github.com/GoogleCloudPlatform/k8s-config-connector/pull/2370/files is merged after you run the controller template. (was wondering why this controller contains many out of date changes).
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
