google_compute_public_advertised_prefix adding in output only shared_secret

[NA2047]

Adding in shared_secret

fixes hashicorp/terraform-provider-google#18171

Please self-review your PR against the review checklist before creating it: https://googlecloudplatform.github.io/magic-modules/contribute/review-pr/

Completing the checklist will help speed up the review process, and we appreciate you spending time on them before sending
your code to be reviewed.

If your PR is still work in progress, please create it in draft mode
-->

Release Note Template for Downstream PRs (will be copied)

compute: added `shared_secret` field to `google_compute_public_advertised_prefix` resource

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 15 insertions(+))
google-beta provider: Diff ( 2 files changed, 15 insertions(+))

[modular-magician]

Tests analytics

Total tests: 966
Passed tests: 892
Skipped tests: 74
Affected tests: 0

Click here to see the affected service packages

• compute

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[roaks3]

LGTM, but wanted to double check, were you able to verify that the field was returned as expected during local testing?

[NA2047]

LGTM, but wanted to double check, were you able to verify that the field was returned as expected during local testing?

I wasn't able to deploy it out unfortunately, I tried to test with the example but I dont have the requires that the docs outline in place https://cloud.google.com/vpc/docs/create-pap#create-pap I would need to create a ROA request I believe as well. I figured since it was an output only field it was ok to just add it in.

[roaks3]

Ok, sounds good. It does seem safe to change, but perhaps we can confirm with the user that this fixes the issue for them.

[roaks3]

Also, could you check the CLA issue? I'm not sure if you need to make the commit with another account.

[NA2047]

Also, could you check the CLA issue? I'm not sure if you need to make the commit with another account.

I'll check with them and see if I can get the, to test

Also, could you check the CLA issue? I'm not sure if you need to make the commit with another account.

Also fixed the CLA issue should be good now I have the app installed

[roaks3]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 15 insertions(+))
google-beta provider: Diff ( 2 files changed, 15 insertions(+))

[modular-magician]

Tests analytics

Total tests: 966
Passed tests: 892
Skipped tests: 74
Affected tests: 0

Click here to see the affected service packages

• compute

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[github-actions]

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[roaks3]

Just waiting on CLA fix to merge

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 15 insertions(+))
google-beta provider: Diff ( 2 files changed, 15 insertions(+))

[modular-magician]

Tests analytics

Total tests: 971
Passed tests: 897
Skipped tests: 74
Affected tests: 0

Click here to see the affected service packages

• compute

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log