Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container: bump gcsfs to GA #11542

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DrFaust92
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)

conatainer: bump `gcfs_config` to GA

@github-actions github-actions bot requested a review from BBBmau August 24, 2024 23:25
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests service/container and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Aug 24, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 112 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 4 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 200
Passed tests: 187
Skipped tests: 13
Affected tests: 0

Click here to see the affected service packages
  • container
#### Non-exercised tests

Tests were added that are GA-only additions and require manual runs:

  • TestAccContainerCluster_withNodePoolDefaults
    $\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@wyardley
Copy link
Contributor

@BBBmau can we try and get #11272 (which has already been approved) through before this one? I suspect this may cause some conflicts there that would not be too fun to resolve.

@wyardley
Copy link
Contributor

Side note: it's merged now, though there are now some conflicts.

@DrFaust92
Copy link
Contributor Author

thanks wyardley, fixed

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Aug 29, 2024
Copy link

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

github-actions bot commented Sep 2, 2024

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

github-actions bot commented Sep 9, 2024

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@wyardley
Copy link
Contributor

wyardley commented Sep 14, 2024

One thing I'm noticing when looking at hashicorp/terraform-provider-google#19482 is that it looks like some of the gcfs_config stuff is already not inside guard clasues, but some of it is? Or am I mixing up node_config and node_config_defaults? edit: I get it now, this is for node_config_defaults.gcfs_config.

Copy link

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests service/container
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants