Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vcr tester Run and RunParallel use options struct #11628

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

trodge
Copy link
Contributor

@trodge trodge commented Sep 3, 2024

Adding an options struct for these methods so that their parameters can be changed without breaking current usage.

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@trodge trodge requested a review from melinath September 4, 2024 16:02
@trodge trodge marked this pull request as ready for review September 4, 2024 16:02
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - could you push a commit to force test runs just to be extra safe?

.ci/magician/cmd/test_terraform_vcr.go Outdated Show resolved Hide resolved
trodge and others added 2 commits September 4, 2024 13:29
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+))
google-beta provider: Diff ( 1 file changed, 2 insertions(+))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+))
google-beta provider: Diff ( 1 file changed, 2 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 51
Passed tests: 50
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • pubsub

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 51
Passed tests: 50
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • pubsub

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

This reverts commit c080d52.
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@trodge trodge merged commit 6dcdc46 into GoogleCloudPlatform:main Sep 4, 2024
10 checks passed
@trodge trodge deleted the magician-vcr branch September 4, 2024 21:18
Mehul3217 pushed a commit to Mehul3217/magic-modules that referenced this pull request Sep 5, 2024
…atform#11628)

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
iyabchen pushed a commit to iyabchen/magic-modules that referenced this pull request Sep 14, 2024
…atform#11628)

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants