Separated tests and skipped failing slack test in google_monitoring_notification_channel #8001

NA2047 · 2023-05-23T14:06:31Z

Potential Fix for Issue14081

Separated Slack test from other working google_monitoring_notification_channel tests

Replace each [ ] with [X] to check it. Switch to the preview view to make it easier to click on links.
These steps will speed up the review process, and we appreciate you spending time on them before sending
your code to be reviewed.
-->
If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

modular-magician · 2023-05-23T14:06:46Z

Oops! It looks like you're using an unknown release-note type in your changelog entries:

bug separated and skipped failing slack test in TestAccMonitoringNotificationChannel_updateSensitiveLabels

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician · 2023-05-23T14:07:16Z

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @SarahFrench, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

Ensuring it's backwards compatible, covers common error cases, etc.
Summarizing the change into a user-facing changelog note.
Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

modular-magician · 2023-05-23T14:26:27Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 76 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 1 file changed, 76 insertions(+), 11 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-05-23T14:28:59Z

Tests analytics

Total tests: 12
Passed tests 12
Skipped tests: 0
Affected tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

SarahFrench

Hi, thanks for your PR! I've read through the changes (+ related issues) and my understanding is that the resource itself doesn't have a bug but the auth token used in the nightly tests for the provider isn't valid, so we want to selectively skip the Slack-related acceptance tests until that is fixed.

I've included a comment suggesting how to skip the tests when they are running in our VCR test environment, but otherwise LGTM. There was an issue above when running tests, but they appear unrelated to this PR as they're related to provider credentials. We can address that later though!

SarahFrench · 2023-05-24T13:54:37Z

mmv1/third_party/terraform/tests/resource_monitoring_notification_channel_test.go

+	// being used to skip test if better test skip is located/created feel free to update
+	if os.Getenv(acctest.TestEnvVar) == "" {
+		t.Skipf("Slack auth_token required for test not to fail, skipping test till interal testing slack can be created; use %s=1 to enable", acctest.TestEnvVar)
+	}


If we want the test to not run in the nightly tests I think using the acctest.SkipIfVcr function (link) would be the best way to selectively skip the Slack acceptance tests until a working auth token is available for the test to use.

Thanks Sarah ill update this

SarahFrench · 2023-06-05T15:14:22Z

There are a bunch of build errors occurring in the checks on this PR that aren't related to the changes you've made. Could you please rebase your branch to incorporate the latest changes on main branch? That should address them- thanks!

)

modular-magician · 2023-06-05T16:35:14Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 71 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 1 file changed, 71 insertions(+), 11 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-06-05T16:37:45Z

Tests analytics

Total tests: 12
Passed tests 12
Skipped tests: 0
Affected tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

modular-magician · 2023-06-05T16:54:22Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 67 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 1 file changed, 67 insertions(+), 9 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-06-05T17:49:55Z

Tests analytics

Total tests: 2771
Passed tests 2476
Skipped tests: 285
Affected tests: 10

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccMonitoringNotificationChannel_updateSensitiveLabels|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplate_infoTypeTransformationsUpdate|TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplateSkipCharactersExample|TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplateBasicExample|TestAccComputeFirewallPolicyRule_multipleRules|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccBigQueryDataTable_bigtable|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccDataSourceAlloydbLocations_basic

Get to know how VCR tests work

modular-magician · 2023-06-05T18:03:30Z

Tests passed during RECORDING mode:
TestAccMonitoringNotificationChannel_updateSensitiveLabels[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplate_infoTypeTransformationsUpdate[Debug log]
TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplateSkipCharactersExample[Debug log]
TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplateBasicExample[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccBigQueryDataTable_bigtable[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]

Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

SarahFrench

This looks good to me - the new version of TestAccMonitoringNotificationChannel_updateSensitiveLabels passed in the latest tests on this PR and the Slack-specific tests haven't run/been mentioned by automation. Thanks for fixing this!

NA2047 · 2023-06-05T18:31:07Z

This looks good to me - the new version of TestAccMonitoringNotificationChannel_updateSensitiveLabels passed in the latest tests on this PR and the Slack-specific tests haven't run/been mentioned by automation. Thanks for fixing this!

Thanks @SarahFrench !

…otification_channel (GoogleCloudPlatform#8001) * Seperated tests and skipped failing slack test * added in skip test based on pr feedback * Import verify package to resource_converter.go (GoogleCloudPlatform#8082) * Updated --------- Co-authored-by: Zhenhua Li <zhenhuali@google.com>

modular-magician requested a review from SarahFrench May 23, 2023 14:07

SarahFrench reviewed May 24, 2023

View reviewed changes

NA2047 added 2 commits June 5, 2023 10:28

Seperated tests and skipped failing slack test

65d0a81

added in skip test based on pr feedback

bcdd7f7

NA2047 force-pushed the issue14081 branch from 332a856 to bcdd7f7 Compare June 5, 2023 14:39

modular-magician requested a review from SarahFrench June 5, 2023 14:40

Import verify package to resource_converter.go (GoogleCloudPlatform#8082

4dda908

)

Updated

539eae8

SarahFrench approved these changes Jun 5, 2023

View reviewed changes

SarahFrench merged commit 9e9c452 into GoogleCloudPlatform:main Jun 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Separated tests and skipped failing slack test in google_monitoring_notification_channel #8001

Separated tests and skipped failing slack test in google_monitoring_notification_channel #8001

NA2047 commented May 23, 2023 •

edited by SarahFrench

Loading

modular-magician commented May 23, 2023

modular-magician commented May 23, 2023

modular-magician commented May 23, 2023

modular-magician commented May 23, 2023

SarahFrench left a comment •

edited

Loading

SarahFrench May 24, 2023

NA2047 May 25, 2023

SarahFrench commented Jun 5, 2023

modular-magician commented Jun 5, 2023

modular-magician commented Jun 5, 2023

modular-magician commented Jun 5, 2023

modular-magician commented Jun 5, 2023

modular-magician commented Jun 5, 2023

SarahFrench left a comment •

edited

Loading

NA2047 commented Jun 5, 2023

Separated tests and skipped failing slack test in google_monitoring_notification_channel #8001

Separated tests and skipped failing slack test in google_monitoring_notification_channel #8001

Conversation

NA2047 commented May 23, 2023 • edited by SarahFrench Loading

modular-magician commented May 23, 2023

modular-magician commented May 23, 2023

modular-magician commented May 23, 2023

Diff report

modular-magician commented May 23, 2023

Tests analytics

SarahFrench left a comment • edited Loading

Choose a reason for hiding this comment

SarahFrench May 24, 2023

Choose a reason for hiding this comment

NA2047 May 25, 2023

Choose a reason for hiding this comment

SarahFrench commented Jun 5, 2023

modular-magician commented Jun 5, 2023

Diff report

modular-magician commented Jun 5, 2023

Tests analytics

modular-magician commented Jun 5, 2023

Diff report

modular-magician commented Jun 5, 2023

Tests analytics

Action taken

modular-magician commented Jun 5, 2023

SarahFrench left a comment • edited Loading

Choose a reason for hiding this comment

NA2047 commented Jun 5, 2023

NA2047 commented May 23, 2023 •

edited by SarahFrench

Loading

SarahFrench left a comment •

edited

Loading

SarahFrench left a comment •

edited

Loading