Move endpoint default handling after TPC universe domain logic #9463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 9 insertions(+), 1 deletion(-)) |
Tests analyticsTotal tests:
|
rileykarson
approved these changes
Nov 13, 2023
swamitagupta
pushed a commit
to swamitagupta/magic-modules
that referenced
this pull request
Nov 14, 2023
davcen
pushed a commit
to davcen/gcp-magic-modules
that referenced
this pull request
Nov 17, 2023
trodge
pushed a commit
to trodge/magic-modules
that referenced
this pull request
Nov 27, 2023
BBBmau
pushed a commit
to BBBmau/magic-modules
that referenced
this pull request
Nov 28, 2023
jialei-chen
pushed a commit
to jialei-chen/magic-modules
that referenced
this pull request
Nov 29, 2023
cheftako
added a commit
to cheftako/k8s-config-connector
that referenced
this pull request
Mar 21, 2024
splits off the default API endpoint half of HandleSDKDefaults func into its own function and calls that new function after TPC universe domain is set. This allows the basepath defaults to use the new domain if set The API custom/default endpoints are not used between when HandleSDKDefaults was called to after the TPC universe logic, so this reorder should be safe. HandleSDKDefaults is also not called anywhere else outside of the one use. provider: fixed an issue where universe domains would not overwrite API endpoints - [X] Run `make ready-pr` to ensure this PR is ready for review.
google-oss-prow bot
added a commit
to GoogleCloudPlatform/k8s-config-connector
that referenced
this pull request
Apr 8, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
splits off the default API endpoint half of HandleSDKDefaults func into its own function and calls that new function after TPC universe domain is set. This allows the basepath defaults to use the new domain if set
The API custom/default endpoints are not used between when HandleSDKDefaults was called to after the TPC universe logic, so this reorder should be safe. HandleSDKDefaults is also not called anywhere else outside of the one use.
Release Note Template for Downstream PRs (will be copied)