Removed deprecated left-pad module dependency. #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
@ahmetb Kindly review the PR and let me know if there is any suggestions or queries. Thanks |
|
/lgtm |
D-Mwanth
pushed a commit
to D-Mwanth/microservices-demo
that referenced
this pull request
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I have removed the dependency of left-pad npm module, we no longer need to use due to following reasons.
https://www.npmjs.com/package/left-pad , This package has been deprecated and author suggested to use native String.prototype.padStart() javascript method.
It doesnt make sense to install a new module to perform just a single line of operation. In our case we were doing return
${m.units}.${m.nanos.toString().padStart(9,'0')} ${m.currency_code}; instead of ${m.units}.${m.nanos.padStart(9,'0')} ${m.currency_code} .