Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file targeted by sed in DeployStack test #2242

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

NimJay
Copy link
Collaborator

@NimJay NimJay commented Nov 1, 2023

sed: can't read main.tf: No such file or directory

@NimJay NimJay requested review from yoshi-approver and a team as code owners November 1, 2023 19:29
Copy link

github-actions bot commented Nov 1, 2023

🚲 PR staged at http://34.29.103.221

@@ -173,7 +173,7 @@ section_open "Testing Online Boutique's front-end is working"
section_close

# Uncomment the line: "deletion_protection = false"
sed -i "s/# deletion_protection/deletion_protection/g" main.tf
sed -i "s/# deletion_protection/deletion_protection/g" ${DIR}/main.tf
Copy link
Collaborator Author

@NimJay NimJay Nov 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This $DIR variable is set at the very top of this file:

DIR="terraform"

and used in the terraform -chdir="$DIR" destroy command below.

@NimJay NimJay merged commit 2c88a0f into main Nov 2, 2023
10 checks passed
@NimJay NimJay deleted the nimjay-deploystack-fix-sed branch November 2, 2023 16:11
D-Mwanth pushed a commit to D-Mwanth/microservices-demo that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants