Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add API verification step in the quickstart README #2252

Merged

Conversation

rozajay
Copy link
Contributor

@rozajay rozajay commented Nov 13, 2023

Background

Introduce an extra step to ensure that users following the instructions can have full confidence in verifying that the services have been successfully enabled for the project.

@rozajay rozajay requested review from yoshi-approver and a team as code owners November 13, 2023 00:56
Copy link

google-cla bot commented Nov 13, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@bourgeoisor
Copy link
Member

@rozajay would you mind following the instructions to sign the CLA? Thank you!

@bourgeoisor bourgeoisor changed the title 📝 Update quickstart instructions chore: Add API verification step in the quickstart README Nov 13, 2023
@rozajay rozajay force-pushed the rozajay-update-quickstart-instructions branch from 5a42648 to 7e41213 Compare November 13, 2023 21:48
@rozajay
Copy link
Contributor Author

rozajay commented Nov 13, 2023

@rozajay would you mind following the instructions to sign the CLA? Thank you!

doneee!

Copy link
Collaborator

@NimJay NimJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you, @rozajay!

@NimJay NimJay merged commit 0fb4c3d into GoogleCloudPlatform:main Nov 14, 2023
4 checks passed
@rozajay rozajay deleted the rozajay-update-quickstart-instructions branch November 14, 2023 22:23
D-Mwanth pushed a commit to D-Mwanth/microservices-demo that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants